ci: harden validation + ci workflows for Gitea act-runner (pre-existing main red fixes) #2

Open

nsatoshi wants to merge 0 commits from devin/ci-hardening-1776555113 into main

pull from: devin/ci-hardening-1776555113

merge into: :main

:main

:integrate/sibling-wip-archive-20260602

:feature/token-aggregation-historical-pricing

:devin/ci-hardening-1776555113

:devin/phase1b-chain138-admin-rotation-1776543648

Conversation 0 Commits - Files Changed -

nsatoshi commented 2026-04-18 16:33:04 -07:00

Owner

Copy Link

Copy Source

Summary

Pre-existing Gitea Actions failures on main that are not caused by any open PR. Observed on run #211 (head 07d9ce4876) before Phase 1b PR #1 was opened. Scope limited to YAML-only changes — no runner-image changes, no new secrets, no submodule surgery.

Failures addressed

1. Terraform Validation (ci.yml::terraform, validation.yml::validate-terraform)

   hashicorp/setup-terraform@v2 / @v3 fails with:

   ::error::Unable to locate executable file: unzip.
   ❌ Failure - Main Setup Terraform
   

   Fix: install unzip in-job (idempotent, no-ops if already present). Better than requiring an act-runner image rebuild.

2. Security Scanning / Container Security Scan (ci.yml::security, validation.yml::validate-security)

   aquasecurity/trivy-action@master fails with:

   ::error::Bad credentials - https://docs.github.com/rest
   ❌ Failure - Main Checkout install script
   ❌ Failure - Main Install Trivy
   

   Root cause: Gitea Actions injects a Gitea token as GITHUB_TOKEN, which api.github.com/repos/aquasecurity/trivy/releases/latest rejects.

   Fix:

   • Pin the action to @0.28.0 + pin version: v0.51.1 → installer skips the releases/latest lookup entirely.
   • Clear GITHUB_TOKEN: "" in the step env → installer falls back to anonymous.
   • Add continue-on-error: true on the validation.yml step so a flaky scan does not block PRs (ci.yml already had this).

3. Upload Trivy results (validation.yml::validate-security)

   github/codeql-action/upload-sarif@v2 targets GitHub's code-scanning API, which Gitea does not host.

   Fix: continue-on-error: true (ci.yml already had this).

Out of scope — flagged for follow-up

These will still fail after this PR merges; they require actual investigation, not a YAML tweak:

• CI/CD Pipeline / Solidity Contracts — lib/dodo-contractV2 pinned commit d946606870b64110218820da44becf2b3e196c8a no longer exists on the remote. Fix options: update the submodule pointer to a new pinned commit, or restore the missing commit on the remote. Likely means pointing the submodule at the Gitea mirror if one exists.
• Validation / validate-kubernetes — kubectl apply --dry-run=client fails with connect: connection refused because it tries to contact localhost:8080. The fix is to pass --validate=false (or run --dry-run=server against a kind cluster). Separate design call.
• CI/CD Pipeline / Lint and Format — forge fmt --check actually finds formatting issues in contracts/. Real code-style work, not CI-plumbing.

Verification

• Inspected logs for master run #211 to confirm the three failure modes above exist independent of any PR.
• No submodules touched; the M lib/* flags in local git status are from an existing detached-HEAD checkout and are not staged.

Scope

• Diff is 2 files, +27 / −2 lines.
• No new secrets required.
• No act-runner image changes required.

## Summary Pre-existing Gitea Actions failures on `main` that are not caused by any open PR. Observed on run #211 (head 07d9ce4876) before Phase 1b PR #1 was opened. Scope limited to YAML-only changes — no runner-image changes, no new secrets, no submodule surgery. ## Failures addressed 1. **Terraform Validation** (`ci.yml::terraform`, `validation.yml::validate-terraform`) `hashicorp/setup-terraform@v2` / `@v3` fails with: ``` ::error::Unable to locate executable file: unzip. ❌ Failure - Main Setup Terraform ``` **Fix:** install `unzip` in-job (idempotent, no-ops if already present). Better than requiring an act-runner image rebuild. 2. **Security Scanning / Container Security Scan** (`ci.yml::security`, `validation.yml::validate-security`) `aquasecurity/trivy-action@master` fails with: ``` ::error::Bad credentials - https://docs.github.com/rest ❌ Failure - Main Checkout install script ❌ Failure - Main Install Trivy ``` Root cause: Gitea Actions injects a Gitea token as `GITHUB_TOKEN`, which `api.github.com/repos/aquasecurity/trivy/releases/latest` rejects. **Fix:** - Pin the action to `@0.28.0` + pin `version: v0.51.1` → installer skips the `releases/latest` lookup entirely. - Clear `GITHUB_TOKEN: ""` in the step env → installer falls back to anonymous. - Add `continue-on-error: true` on the validation.yml step so a flaky scan does not block PRs (ci.yml already had this). 3. **Upload Trivy results** (`validation.yml::validate-security`) `github/codeql-action/upload-sarif@v2` targets GitHub's code-scanning API, which Gitea does not host. **Fix:** `continue-on-error: true` (ci.yml already had this). ## Out of scope — flagged for follow-up These will still fail after this PR merges; they require actual investigation, not a YAML tweak: - **`CI/CD Pipeline / Solidity Contracts`** — `lib/dodo-contractV2` pinned commit `d946606870b64110218820da44becf2b3e196c8a` no longer exists on the remote. Fix options: update the submodule pointer to a new pinned commit, or restore the missing commit on the remote. Likely means pointing the submodule at the Gitea mirror if one exists. - **`Validation / validate-kubernetes`** — `kubectl apply --dry-run=client` fails with `connect: connection refused` because it tries to contact `localhost:8080`. The fix is to pass `--validate=false` (or run `--dry-run=server` against a kind cluster). Separate design call. - **`CI/CD Pipeline / Lint and Format`** — `forge fmt --check` actually finds formatting issues in `contracts/`. Real code-style work, not CI-plumbing. ## Verification - Inspected logs for master run #211 to confirm the three failure modes above exist independent of any PR. - No submodules touched; the `M lib/*` flags in local `git status` are from an existing detached-HEAD checkout and are not staged. ## Scope - Diff is **2 files, +27 / −2 lines**. - No new secrets required. - No act-runner image changes required.

nsatoshi added 19 commits 2026-04-18 16:33:04 -07:00

fix(token-aggregation): tolerate missing market data tables 089da29b9b

fix(deployment): load env safely under nounset 59cdd5af60

fix(env): load derived dotenv vars under nounset a923d7b397

fix(config): drop unsupported miner-coinbase from validators 162a7d5b03

Enforce asset-scoped governance metadata controls 4a641475cd

Require dual-jurisdiction approval for asset-scoped governance 7678218172

chore: gitignore Foundry artifacts/ and untrack build JSON ... 0fb7bba07b

artifacts/ is regenerated by forge build; matches existing out/ and cache/ ignores.

Made-with: Cursor

feat: bridges, PMM, flash workflow, token-aggregation, and deployment docs ... 76aa419320

- CCIP/trustless bridge contracts, GRU tokens, DEX/PMM tests, reserve vault.
- Token-aggregation service routes, planner, chain config, relay env templates.
- Config snapshots and multi-chain deployment markdown updates.
- gitignore services/btc-intake/dist/ (tsc output); do not track dist.

Run forge build && forge test before deploy (large solc graph).

Made-with: Cursor

config(besu): allowlist ops EOA 0xB2dE… for core/Thirdweb admin RPC deploy ... 662b35ad69

Made-with: Cursor

Flash unwinder contracts and scripts, relay lane tuning, trustless bridge and token-aggregation updates. ... 6817f53591

Made-with: Cursor

refactor(bridge): trustless swap stack and fork test cleanups ... f19c771760

Tighten EnhancedSwapRouter, InboxETH, SwapRouter, MerkleProofVerifier; align
DEXIntegration and ForkTests with updated behavior.

Made-with: Cursor

fix(token-aggregation): restore Chain 138 cAUSDT fallback for report API ... 06c4bebcb7

Aligns canonical-tokens FALLBACK_ADDRESSES with smart-contracts-master.json
so /api/v1/report/token-list includes cAUSDT when env overrides are absent.

Made-with: Cursor

fix(relay): defer on inventory probe errors; optional retry without budget ... 8ec6af94d5

- MessageQueue: resetRetryCount and retry({ increment: false }) for shedder/inventory paths
- RelayService: treat bridge_inventory_probe like other soft-failure scopes; wrap inventory check in try/catch
- Token aggregation: catch DB pool lookup errors and fall back to live DODO path
- Mainnet WETH profile: START_BLOCK=latest; extend RELAY_SKIP_MESSAGE_IDS for backlog hygiene
- Extend relay test.js for deferred requeue behavior

Made-with: Cursor

refactor(archive): move historical contracts and adapters to archive directory ... 2b52cc6e32

- Archived multiple non-EVM adapters (Algorand, Hedera, Tron, TON, Cosmos, Solana) and compliance contracts (IndyVerifier) to `archive/solidity/contracts/`.
- Updated documentation to reflect the historical status of archived components.
- Adjusted `foundry.toml` and `README.md` for clarity on historical dependencies and configurations.
- Enhanced Makefile and package.json scripts for improved contract testing and building processes.
- Removed obsolete contracts (AlltraCustomBridge, CommodityCCIPBridge, ISO4217WCCIPBridge, VaultBridgeAdapter) from the main directory.
- Updated implementation reports to indicate archived status for various components.

Add managed quote-push treasury workflows 7517869ea6

Archive legacy status docs and canonicalize genesis entrypoints 79750d92e6

Deploy Chain 138 canonical non-gas PMM mesh da78073104

feat: expand non-evm relay and route planning support 843cdbf71c

ci: harden validation + ci workflows for Gitea act-runner ... 4c5f1649bc

Pre-existing failures observed on main (run #211) before Phase 1b PR #1
existed:

1. Terraform Validation: hashicorp/setup-terraform fails with "Unable
   to locate executable file: unzip" on act-runner image. Install
   unzip in-job (idempotent, no-ops if already present).

2. Container Security Scan + Run Trivy container scan: aquasecurity/
   trivy-action@master emits "Bad credentials - https://docs.github.com/
   rest" when installing the Trivy binary. Root cause: Gitea Actions
   injects a Gitea token as GITHUB_TOKEN, which api.github.com rejects.
   Pin the action to @0.28.0 + trivy binary version to v0.51.1 (skips
   the GitHub releases API lookup), and clear GITHUB_TOKEN in the step
   env so the installer falls back to anonymous access. Mark the step
   continue-on-error so a flaky scan does not block PRs.

3. Upload Trivy results (validation.yml only): github/codeql-action/
   upload-sarif targets GitHub's code-scanning API, which Gitea does
   not host. Mark continue-on-error so the job does not fail.

Out of scope (not addressable via YAML-only changes):
  - lib/dodo-contractV2 pinned commit d946606870b64110218820da44becf2b3e196c8a
    no longer exists on the remote; Solidity Contracts job will keep
    failing until the submodule pointer is refreshed or the remote is
    restored.
  - validate-kubernetes kubectl dry-run fails with connection refused
    because no local API server is running on the runner; that needs
    switching to `kubectl apply --dry-run=client --validate=false` or
    a local kubeconfig, which is a separate design choice.

Co-Authored-By: Nakamoto, S <defi@defi-oracle.io>

nsatoshi added 1 commit 2026-04-18 16:39:31 -07:00

ci: revert trivy-action pin to @master; keep pinned binary version ... 1826618f12

Tag @0.28.0 does not exist in act-runner's reference resolution
("Unable to resolve 0.28.0: reference not found"). Use @master and
rely on the 'version: v0.51.1' input to pin the Trivy binary so the
installer still skips api.github.com releases/latest.

Co-Authored-By: Nakamoto, S <defi@defi-oracle.io>

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin devin/ci-hardening-1776555113:devin/ci-hardening-1776555113

git checkout devin/ci-hardening-1776555113

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Bug report or regression

documentation

Documentation task or copy update

enhancement

Feature request or UX improvement

maintenance

Tooling, cleanup, or admin task

question

Need clarification or investigation

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

70rn4710n (FAFO) A.r.yavari SEG nsatoshi zardashtways44

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: d-bis/smom-dbis-138#2