d-bis/proxmox
4
0
Fork 0
Code Issues 2 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

docs(chain138): Phase 4b runbook for EnhancedSwapRouterV2 + adapters #19

Open
nsatoshi wants to merge 1 commits from devin/1777471106-phase4b-v2-runbook into master
pull from: devin/1777471106-phase4b-v2-runbook
merge into: d-bis:master
Conversation 1 Commits 1 Files Changed 3 +122
nsatoshi commented 2026-04-29 14:03:11 +00:00
Owner
Copy Link

Summary

Adds the operational runbook for the upcoming Phase 4b deploy of EnhancedSwapRouterV2 + 6 IRouteExecutorAdapter contracts on Chain 138, mirroring the structure of the Phase 3 / Phase 3j runbooks. Companion to PR #1 on Order-of-Hospitallers/smom-dbis-138 ("deploy(EnhancedSwapRouterV2): register 3 cBTC DODO pools (Phase 3j parity)") which is deploy-script-only.

Files:

  • New: docs/bridge/trustless/PHASE4B_V2_DEPLOY_RUNBOOK.md — V1 vs V2 differences, step-by-step pre-flight + dry-run + broadcast + verification commands, hand-back format, scope-reminder for what V2 does NOT do (no dApp wiring, no V1 changes, no Balancer pool ids yet).
  • Update: docs/11-references/ADDRESS_MATRIX_AND_STATUS.md §1.6 — flags EnhancedSwapRouterV2 as "Pending — Phase 4b", points at the runbook + the smom-dbis-138 PR.
  • Update: docs/11-references/PMM_DEX_ROUTING_STATUS.md §2.1 — same flag with a one-paragraph context for routing reviewers.

V2 is parallel infra. It does not touch the deployed V1 router (0xE6Cc7643…) or the dApp's route registry. The dApp continues to use V1 + the existing ?useEnhancedRouter=1 per-leg dispatch path until a separate Phase 4c PR opts traffic into V2 behind a feature flag.

The Paris-only constraint (Chain 138 / Besu rejects PUSH0) is honored via FOUNDRY_PROFILE=chain138_legacy + --evm-version paris in the runbook commands. Same root cause as the V1 broadcast OOG that we fixed in the prior session.

Review & Testing Checklist for Human

  • Read through PHASE4B_V2_DEPLOY_RUNBOOK.md end-to-end and confirm the env-var set + post-deploy verification reads match what your LAN dotenv actually exposes (in particular RPC_URL_138, PRIVATE_KEY, DODO_PMM_PROVIDER_ADDRESS).
  • Confirm parity: the deploy script (in smom-dbis-138 PR #1) registers the same 11 DODO pairs as V1 (8 originals + 3 cBTC pools added Phase 3j). Spot-check 2–3 pool addresses in the runbook against chain138-tokens-and-pmm.mdc.
  • Decide whether to wire optional BALANCER_WETH_USDT_POOL_ID / BALANCER_WETH_USDC_POOL_ID env vars before broadcast, or defer Balancer until pool ids are discovered.

Recommended test plan: this PR is doc-only. The actual deploy is a follow-up — after merging this PR (and smom-dbis-138 PR #1), run the steps in PHASE4B_V2_DEPLOY_RUNBOOK.md from a LAN host. Hand back the 8 deployed addresses + the 4 verification reads.

Notes

  • This PR does NOT change V1's status row in the address matrix — V1 stays "Deployed 2026-04-22 (Phase 3, EVM Paris)".
  • After the V2 broadcast lands, a follow-up PR should flip the V2 row from "Pending" to "Deployed at 0x… (11 pools wired)" with the actual addresses.
  • LAN deploy prompt also lives at ~/test-plans/phase4b-cursor-lan-prompt.md on the Devin VM (same content; the in-repo runbook is the canonical archived copy).
## Summary Adds the operational runbook for the upcoming Phase 4b deploy of `EnhancedSwapRouterV2` + 6 `IRouteExecutorAdapter` contracts on Chain 138, mirroring the structure of the Phase 3 / Phase 3j runbooks. Companion to PR #1 on `Order-of-Hospitallers/smom-dbis-138` ("deploy(EnhancedSwapRouterV2): register 3 cBTC DODO pools (Phase 3j parity)") which is deploy-script-only. Files: - New: `docs/bridge/trustless/PHASE4B_V2_DEPLOY_RUNBOOK.md` — V1 vs V2 differences, step-by-step pre-flight + dry-run + broadcast + verification commands, hand-back format, scope-reminder for what V2 does NOT do (no dApp wiring, no V1 changes, no Balancer pool ids yet). - Update: `docs/11-references/ADDRESS_MATRIX_AND_STATUS.md` §1.6 — flags `EnhancedSwapRouterV2` as "Pending — Phase 4b", points at the runbook + the smom-dbis-138 PR. - Update: `docs/11-references/PMM_DEX_ROUTING_STATUS.md` §2.1 — same flag with a one-paragraph context for routing reviewers. V2 is **parallel infra**. It does not touch the deployed V1 router (`0xE6Cc7643…`) or the dApp's route registry. The dApp continues to use V1 + the existing `?useEnhancedRouter=1` per-leg dispatch path until a separate Phase 4c PR opts traffic into V2 behind a feature flag. The Paris-only constraint (Chain 138 / Besu rejects `PUSH0`) is honored via `FOUNDRY_PROFILE=chain138_legacy` + `--evm-version paris` in the runbook commands. Same root cause as the V1 broadcast OOG that we fixed in the prior session. ## Review & Testing Checklist for Human - [ ] Read through `PHASE4B_V2_DEPLOY_RUNBOOK.md` end-to-end and confirm the env-var set + post-deploy verification reads match what your LAN dotenv actually exposes (in particular `RPC_URL_138`, `PRIVATE_KEY`, `DODO_PMM_PROVIDER_ADDRESS`). - [ ] Confirm parity: the deploy script (in `smom-dbis-138` PR #1) registers the same 11 DODO pairs as V1 (8 originals + 3 cBTC pools added Phase 3j). Spot-check 2–3 pool addresses in the runbook against `chain138-tokens-and-pmm.mdc`. - [ ] Decide whether to wire optional `BALANCER_WETH_USDT_POOL_ID` / `BALANCER_WETH_USDC_POOL_ID` env vars before broadcast, or defer Balancer until pool ids are discovered. Recommended test plan: this PR is doc-only. The actual deploy is a follow-up — after merging this PR (and `smom-dbis-138` PR #1), run the steps in `PHASE4B_V2_DEPLOY_RUNBOOK.md` from a LAN host. Hand back the 8 deployed addresses + the 4 verification reads. ### Notes - This PR does NOT change V1's status row in the address matrix — V1 stays "Deployed 2026-04-22 (Phase 3, EVM Paris)". - After the V2 broadcast lands, a follow-up PR should flip the V2 row from "Pending" to "Deployed at 0x… (11 pools wired)" with the actual addresses. - LAN deploy prompt also lives at `~/test-plans/phase4b-cursor-lan-prompt.md` on the Devin VM (same content; the in-repo runbook is the canonical archived copy).
nsatoshi added 1 commit 2026-04-29 14:03:12 +00:00
docs(chain138): Phase 4b runbook for EnhancedSwapRouterV2 + adapters
Some checks failed
AI Code Review / claude-review (pull_request) Failing after 1m3s
Details
Validate (PR) / run-all-validation (pull_request) Failing after 57s
Details
453f50aa59 
Add docs/bridge/trustless/PHASE4B_V2_DEPLOY_RUNBOOK.md mirroring the LAN deploy prompt for V2 (parallel infra to V1, doesn't change dApp routing until Phase 4c).

Flag both ADDRESS_MATRIX_AND_STATUS.md \u00a71.6 and PMM_DEX_ROUTING_STATUS.md \u00a72.1 with EnhancedSwapRouterV2 status "Pending Phase 4b" pointing at smom-dbis-138 PR #1 (deploy-script-only).

Co-Authored-By: Nakamoto, S <defi@defi-oracle.io>
gitea-actionsbot commented 2026-04-29 14:03:43 +00:00
Copy Link

Claude encountered an error —— View job

I'll analyze this and get back to you.

**Claude encountered an error** —— [View job](http://127.0.0.1:3000/d-bis/proxmox/actions/runs/227) --- I'll analyze this and get back to you.
Some checks failed
AI Code Review / claude-review (pull_request) Failing after 1m3s
Details
Validate (PR) / run-all-validation (pull_request) Failing after 57s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin devin/1777471106-phase4b-v2-runbook:devin/1777471106-phase4b-v2-runbook
git checkout devin/1777471106-phase4b-v2-runbook
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
70rn4710n A.r.yavari SEG nsatoshi
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: d-bis/proxmox#19
Delete Branch "devin/1777471106-phase4b-v2-runbook"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?