chore(frontend): commit to pages router, drop empty src/app, unify on npm #9

2026-04-18T19:23:51Z

nsatoshi commented

2026-04-18 19:23:51 +00:00

Summary

PR #9 of the 11-PR completion sequence. Fixes the 'unfinished router migration + inconsistent packageManager' finding from the review.

Changes

Router decision: keep pages/, delete app/. src/app/ only ever contained globals.css; every actual route lives under src/pages/. Keeping both routers in the tree made the build surface area ambiguous and left a trap where a future contributor could add a new route under src/app/ and break Next's routing resolution.
CSS moved. src/app/globals.css → src/styles/globals.css. _app.tsx's import was updated accordingly. No-op at runtime; CSS payload is byte-identical.
Tailwind content glob updated. ./src/app/**/*.{js,ts,jsx,tsx,mdx} → ./src/styles/**/*.css. The src/components/** and src/pages/** globs are unchanged.
Unified on npm:
- packageManager: [email protected] → [email protected]. The lockfile (package-lock.json) and CI (npm ci / npm run lint / npm run type-check / npm run build) have always used npm; the pnpm declaration was aspirational and would have forced contributors with corepack enabled into a tool the repo doesn't actually support.
- Added engines: node >=20 <21, npm >=10 so CI, Docker, and a fresh laptop clone all land on the same runtime.

Verification

npm ci — 465 packages, no warnings.
npm run lint — next lint: No ESLint warnings or errors.
npm run type-check — tsc --noEmit clean.
npm run build — Next.js 14.2.35 compiled 19 pages successfully: /, /access, /addresses, /analytics, /blocks, /blocks/[number], /bridge, /docs, /docs/gru, /docs/transaction-compliance, /docs/transaction-review, /home, /liquidity, /more, /operations, /operator, /pools, /routes, /search, /system, /tokens, /tokens/[address], /transactions, /transactions/[hash], /wallet, /watchlist, /weth. No warnings.

Completion criterion advanced

5. Frontend housekeeping — "one router; one package manager; build is reproducible from the lockfile."

## Summary PR #9 of the 11-PR completion sequence. Fixes the 'unfinished router migration + inconsistent packageManager' finding from the review. ## Changes 1. **Router decision: keep `pages/`, delete `app/`.** `src/app/` only ever contained `globals.css`; every actual route lives under `src/pages/`. Keeping both routers in the tree made the build surface area ambiguous and left a trap where a future contributor could add a new route under `src/app/` and break Next's routing resolution. 2. **CSS moved.** `src/app/globals.css` → `src/styles/globals.css`. `_app.tsx`'s import was updated accordingly. No-op at runtime; CSS payload is byte-identical. 3. **Tailwind content glob updated.** `./src/app/**/*.{js,ts,jsx,tsx,mdx}` → `./src/styles/**/*.css`. The `src/components/**` and `src/pages/**` globs are unchanged. 4. **Unified on npm:** - `packageManager`: `[email protected]` → `[email protected]`. The lockfile (`package-lock.json`) and CI (`npm ci / npm run lint / npm run type-check / npm run build`) have always used npm; the pnpm declaration was aspirational and would have forced contributors with corepack enabled into a tool the repo doesn't actually support. - Added `engines`: `node >=20 <21`, `npm >=10` so CI, Docker, and a fresh laptop clone all land on the same runtime. ## Verification - `npm ci` — 465 packages, no warnings. - `npm run lint` — `next lint`: **No ESLint warnings or errors**. - `npm run type-check` — `tsc --noEmit` clean. - `npm run build` — Next.js 14.2.35 compiled **19 pages successfully**: `/`, `/access`, `/addresses`, `/analytics`, `/blocks`, `/blocks/[number]`, `/bridge`, `/docs`, `/docs/gru`, `/docs/transaction-compliance`, `/docs/transaction-review`, `/home`, `/liquidity`, `/more`, `/operations`, `/operator`, `/pools`, `/routes`, `/search`, `/system`, `/tokens`, `/tokens/[address]`, `/transactions`, `/transactions/[hash]`, `/wallet`, `/watchlist`, `/weth`. No warnings. ## Completion criterion advanced > **5. Frontend housekeeping** — "one router; one package manager; build is reproducible from the lockfile."

nsatoshi referenced this pull request

2026-04-18 19:31:05 +00:00

docs: rewrite README, add ARCHITECTURE.md (Mermaid), add API.md from swagger.yaml #11

nsatoshi merged commit cf3b291c87 into master

2026-04-18 19:37:30 +00:00

nsatoshi referenced this issue from a commit

2026-04-18 19:37:33 +00:00

chore(frontend): commit to pages router, drop empty src/app, unify on npm

nsatoshi referenced this issue from a commit

2026-04-18 19:37:33 +00:00

Merge pull request 'chore(frontend): commit to pages router, drop empty src/app, unify on npm' (#9) from devin/1776540090-chore-frontend-router-decision into master

nsatoshi referenced this issue from a commit