d-bis/app-ethereum
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,122 Commits 1 Branch 0 Tags
b120fc6565e4e7263db6e47fcf98c94bda8eb2bd
Commit Graph
1122 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jorge Martins b120fc6565 fix code style 2022-11-08 09:56:00 +01:00
Jorge Martins ead85a0aaa Add funcs to avoid tricking user when using plugin 
Usually the length of an array is sent in a parameter.
Most of the times the developer simply uses U2BE/U4BE to get this length. It
is possible to forge a tx with a `length > sizeof(uint16_t/uint32_t)` and trick the
user into signing something different from what is shown.

For instance consider the following parameter:
00 ... 01 00 00 00 01

if the developer uses U2BE/U4BE, it is possible that this length is shown to the user
and if it is, the user will see the length as 1.
 2022-11-08 09:44:37 +01:00
apaillier-ledgerandGitHub 912c8afca6 Merge pull request #360 from LedgerHQ/apr/version_bump 
Version bump to 1.10.1-dev
 2022-11-02 10:26:45 +01:00
Alexandre Paillier 878355abfd Fix contract support doc name 
Introduced by 30f8c50e
 2022-10-28 15:56:09 +02:00
Alexandre Paillier 8403fdaac4 Version bump to 1.10.1-dev 2022-10-27 18:11:12 +02:00
apaillier-ledgerandGitHub 56f66cc94c Merge pull request #359 from LedgerHQ/develop 
App release 1.10.0
 2022-10-27 17:56:10 +02:00
apaillier-ledgerandGitHub a50ce1de70 Merge pull request #358 from LedgerHQ/apr/release_changelog 
1.10.0 changelog update & non-dev version number
 2022-10-26 18:43:44 +02:00
Alexandre Paillier 1e800478ba Changelog update + removed -dev version suffix 2022-10-26 18:33:54 +02:00
apaillier-ledgerandGitHub f799176aa5 Merge pull request #357 from LedgerHQ/feature/apr/lite_container 
Switch to using the lite App-Builder container
 2022-10-26 18:33:29 +02:00
Alexandre Paillier aabf44e0d9 Switch to using the lite container 2022-10-26 18:18:54 +02:00
apaillier-ledgerandGitHub 69f7a4a0ba Merge pull request #327 from LedgerHQ/apr/feature/eip712 
EIP-712 clear-signing
 2022-10-26 17:58:39 +02:00
Alexandre Paillier 314eba1a64 CI fix 
Needed by the update of the app-builder container
 2022-10-26 17:18:30 +02:00
Alexandre Paillier 174d35782f Review fixes 2022-10-26 14:54:10 +02:00
Alexandre Paillier 4af091f326 Fix CI with newer ragger version 2022-10-24 10:18:56 +02:00
Alexandre Paillier c158c3e502 Better split between business logic & UI code for EIP-712 2022-10-24 10:18:51 +02:00
Alexandre Paillier 109dffc70e Better context check for EIP712 sign 
It was possible to define empty structs without any fields and right after, trigger the EIP712 sign UI flow for blank domain & message hashes.
Added checks if there is actually anything relevant to sign.
 2022-10-18 11:51:39 +02:00
Jorge MartinsandGitHub 0b288cd924 Eip712 review (#355) 
* Possible security fix.

It is possible to send a new structure definition after sending a structure implementation, which makes the app treat unrestricted data as if it was a well defined structure.
This commit tries to fix that behaviour. Once a structure implementation is sent, we consider all structures to be defined and we do not allow new definitions.

* Fix previous commit
 2022-10-18 11:09:00 +02:00
Alexandre Paillier 3e3da4c814 Minimize duplicated code in cross devices settings UX flow 2022-10-17 11:57:17 +02:00
Alexandre Paillier c803322f3c Review fixes 2022-10-17 11:57:16 +02:00
Alexandre Paillier d297a66951 Enforce proper memory alignment on APDU buffer for response status words 2022-10-17 11:57:16 +02:00
Alexandre Paillier fe3f61c7a0 Updated changelog 2022-10-17 11:57:10 +02:00
Alexandre Paillier 2474bdb81a Merge remote-tracking branch 'origin/develop' into HEAD 2022-10-17 11:44:28 +02:00
apaillier-ledgerandGitHub 17665478d9 Merge pull request #354 from LedgerHQ/apr/version_bump 
Version bump to 1.10.0
 2022-10-14 18:20:55 +02:00
Alexandre Paillier d2659ed332 Version bump to 1.10.0 2022-10-14 17:42:20 +02:00
cbouvet-ledgerandGitHub 75b2b7b850 Merge pull request #353 from LedgerHQ/cbo-stark-utils 
move some stack utility functions to common
 2022-10-14 12:01:40 +02:00
Clement Bouvet 51e4ab2a6f move some stack utility functions to common 2022-10-14 11:02:11 +02:00
cbouvet-ledgerandGitHub 93ff399fb5 Merge pull request #352 from LedgerHQ/cbo-plugins-common 
commonise plugins
 2022-10-14 10:54:52 +02:00
Clement Bouvet 2dd757786d commonise plugins 2022-10-14 10:40:00 +02:00
apaillier-ledgerandGitHub a78ca5bce5 Merge pull request #351 from LedgerHQ/develop 
App release 1.9.20
 2022-10-11 10:24:40 +02:00
apaillier-ledgerandGitHub 3c73234cb8 Merge pull request #350 from LedgerHQ/apr/release_changelog 
Changelog update & non-dev version number
 2022-10-10 15:39:11 +02:00
Alexandre Paillier e34a9f55e9 Changelog update + removed -dev version suffix 2022-10-10 15:18:45 +02:00
apaillier-ledgerandGitHub d0ae7b5cd7 Merge pull request #349 from LedgerHQ/fix-swap-variant 
fix: allow swap feature on all ETH variants
 2022-10-10 15:07:34 +02:00
Alexandre Paillier 3da1e2fd86 Updated changelog 2022-10-10 14:56:58 +02:00
Edouard Merle c09e17a3e8 fix: allow swap feature on all ETH variants 2022-10-10 14:43:40 +02:00
Jorge MartinsandGitHub fa44edaeeb Merge pull request #348 from LedgerHQ/plugin-error-handling 
Abort signing process ETH_PLUGIN_QUERY_*
 2022-10-07 17:11:04 +02:00
Jorge Martins 4c78d485a1 Abort signing process ETH_PLUGIN_QUERY_* 
Before was not possible to abort the signing process even if the plugin
return an error code. According to the docs any return code besides
ETH_PLUGIN_RESULT_OK should abort the signing process.
 2022-10-07 16:40:27 +02:00
apaillier-ledgerandGitHub 8034e269fb Merge pull request #347 from LedgerHQ/apr/feature/eip191_ui_split 
Fix EIP-191 UI split + changelog update
 2022-10-06 15:41:39 +02:00
Alexandre Paillier f43d9c4dc7 Fix EIP-191 UI split 2022-10-06 15:11:30 +02:00
Alexandre Paillier 82299217de Fix EIP-191 changelog 
Wasn't in line with the latest modifications
 2022-10-06 15:10:25 +02:00
apaillier-ledgerandGitHub 50e079813e Merge pull request #346 from LedgerHQ/apr/feature/full_eip191_lns 
Activate full EIP-191 implementation on LNS
 2022-10-04 16:05:06 +02:00
Alexandre Paillier d78bece8d2 Fix Zemu tests 2022-10-04 14:27:22 +02:00
Alexandre Paillier e9ecf2e109 Activate full EIP-191 implementation on LNS + with adequate wording 2022-10-04 13:59:50 +02:00
apaillier-ledgerandGitHub eaeb7cb4c2 Merge pull request #345 from LedgerHQ/purge/compound_plugin 
[clean] Removing compound-related plugin code
 2022-10-03 15:45:46 +02:00
Lucas PASCALandAlexandre Paillier 3ff15a16e3 [clean] Removing compound-related plugin code 2022-10-03 14:49:54 +02:00
lpascal-ledgerandGitHub d839c35d2e Merge pull request #342 from LedgerHQ/update/changelog 
Update changelog for 1.9.20
 2022-09-20 11:28:45 +02:00
Lucas PASCAL 1e3083a6f9 Update changelog for 1.9.20 2022-09-19 17:05:35 +02:00
lpascal-ledgerandGitHub 8f1c3f91a7 Merge pull request #339 from LedgerHQ/apr/feature/eip191_full_length 
EIP-191 UI improvements
 2022-09-19 17:01:20 +02:00
Lucas PASCAL 3f294f9582 Minor fixes after review 2022-09-16 14:43:51 +02:00
Alexandre Paillier 0769eaa651 Updated changelog 2022-09-15 17:11:22 +02:00
Alexandre Paillier 29476ccf99 Proper UI wording on EIP-191 continue/skip screen 2022-09-15 17:11:22 +02:00