Commit Graph
1143 Commits
Author SHA1 Message Date
apaillier-ledgerandGitHub 847a172584 Merge pull request #374 from LedgerHQ/apr/ci/fix_pr_auto_assign
Fix PR auto-assign GitHub action
2022-11-16 18:34:06 +01:00
lpascal-ledgerandGitHub a3ab9cbfa0 Merge pull request #373 from LedgerHQ/fix/sdk_update_action
[fix] 'github-push-action' does not seem to cope with src:dst git push syntax
2022-11-16 14:25:16 +01:00
Alexandre Paillier 3e455250d2 Explicit github action version, v1 tag does not exist 2022-11-16 13:52:57 +01:00
Lucas PASCAL 55a4b48f18 [fix] 'github-push-action' does not seem to cope with src:dst git push syntax 2022-11-16 12:14:57 +01:00
apaillier-ledgerandGitHub 4ae512fb80 Merge pull request #370 from LedgerHQ/apr/ci/fix_deprecation_warnings
Update actions to fix deprecation warnings
2022-11-16 11:28:54 +01:00
Jorge MartinsandGitHub 26f8b836f6 Merge pull request #361 from LedgerHQ/improv-dev-experience
Add helpers to avoid tricking user when using a plugin
2022-11-16 11:09:04 +01:00
Alexandre Paillier 60fc9c1417 Add missing function return type to SDK generation script for consistency 2022-11-15 18:11:03 +01:00
Alexandre Paillier fcc9f7ab84 Update actions to fix deprecation warnings 2022-11-15 18:07:56 +01:00
apaillier-ledgerandGitHub 1b1d54c1e4 Merge pull request #367 from LedgerHQ/cbo-fix-712v0-common-ui
cmd_signMessage712.c: use common ui
2022-11-10 17:21:16 +01:00
apaillier-ledgerandGitHub 797a0e66d8 Merge pull request #368 from LedgerHQ/apr/version_bump
Version bump to 1.10.2-dev
2022-11-10 17:02:31 +01:00
Alexandre Paillier f26f5e2185 Version bump to 1.10.2-dev 2022-11-10 16:43:55 +01:00
Clement Bouvet 800116ee9d cmd_signMessage712.c: use common ui 2022-11-10 13:33:59 +01:00
apaillier-ledgerandGitHub 793bc57091 Merge pull request #366 from LedgerHQ/develop
App release 1.10.1
2022-11-10 11:58:59 +01:00
apaillier-ledgerandGitHub 3a67073be3 Merge pull request #365 from LedgerHQ/apr/release_changelog
1.10.1 changelog update & non-dev version number
2022-11-09 16:49:36 +01:00
Alexandre Paillier 4836ba49b2 Changelog update + removed -dev version suffix 2022-11-09 16:30:14 +01:00
apaillier-ledgerandGitHub 93e47d41a7 Merge pull request #364 from LedgerHQ/apr/bugfix/eip712_latency_weakness
Fix potential crash with slow APDU transport
2022-11-09 16:13:35 +01:00
Alexandre Paillier 7ea69d17fa CI Fix 2022-11-09 15:33:47 +01:00
Alexandre Paillier d4b4b5e830 Disable button clicks while waiting for EIP-712 APDU 2022-11-09 14:03:29 +01:00
Jorge Martins a49752fe9b allzeroes const void* buf 2022-11-08 11:23:14 +01:00
Jorge Martins 65d2c88f2d update docs 2022-11-08 10:22:26 +01:00
Jorge Martins 51db776de6 add const to parameters 2022-11-08 09:57:24 +01:00
Jorge Martins b120fc6565 fix code style 2022-11-08 09:56:00 +01:00
Jorge Martins ead85a0aaa Add funcs to avoid tricking user when using plugin
Usually the length of an array is sent in a parameter.
Most of the times the developer simply uses U2BE/U4BE to get this length. It
is possible to forge a tx with a `length > sizeof(uint16_t/uint32_t)` and trick the
user into signing something different from what is shown.

For instance consider the following parameter:
00 ... 01 00 00 00 01

if the developer uses U2BE/U4BE, it is possible that this length is shown to the user
and if it is, the user will see the length as 1.
2022-11-08 09:44:37 +01:00
apaillier-ledgerandGitHub 912c8afca6 Merge pull request #360 from LedgerHQ/apr/version_bump
Version bump to 1.10.1-dev
2022-11-02 10:26:45 +01:00
Alexandre Paillier 878355abfd Fix contract support doc name
Introduced by 30f8c50e
2022-10-28 15:56:09 +02:00
Alexandre Paillier 8403fdaac4 Version bump to 1.10.1-dev 2022-10-27 18:11:12 +02:00
apaillier-ledgerandGitHub 56f66cc94c Merge pull request #359 from LedgerHQ/develop
App release 1.10.0
2022-10-27 17:56:10 +02:00
apaillier-ledgerandGitHub a50ce1de70 Merge pull request #358 from LedgerHQ/apr/release_changelog
1.10.0 changelog update & non-dev version number
2022-10-26 18:43:44 +02:00
Alexandre Paillier 1e800478ba Changelog update + removed -dev version suffix 2022-10-26 18:33:54 +02:00
apaillier-ledgerandGitHub f799176aa5 Merge pull request #357 from LedgerHQ/feature/apr/lite_container
Switch to using the lite App-Builder container
2022-10-26 18:33:29 +02:00
Alexandre Paillier aabf44e0d9 Switch to using the lite container 2022-10-26 18:18:54 +02:00
apaillier-ledgerandGitHub 69f7a4a0ba Merge pull request #327 from LedgerHQ/apr/feature/eip712
EIP-712 clear-signing
2022-10-26 17:58:39 +02:00
Alexandre Paillier 314eba1a64 CI fix
Needed by the update of the app-builder container
2022-10-26 17:18:30 +02:00
Alexandre Paillier 174d35782f Review fixes 2022-10-26 14:54:10 +02:00
Alexandre Paillier 4af091f326 Fix CI with newer ragger version 2022-10-24 10:18:56 +02:00
Alexandre Paillier c158c3e502 Better split between business logic & UI code for EIP-712 2022-10-24 10:18:51 +02:00
Alexandre Paillier 109dffc70e Better context check for EIP712 sign
It was possible to define empty structs without any fields and right after, trigger the EIP712 sign UI flow for blank domain & message hashes.
Added checks if there is actually anything relevant to sign.
2022-10-18 11:51:39 +02:00
Jorge MartinsandGitHub 0b288cd924 Eip712 review (#355)
* Possible security fix.

It is possible to send a new structure definition after sending a structure implementation, which makes the app treat unrestricted data as if it was a well defined structure.
This commit tries to fix that behaviour. Once a structure implementation is sent, we consider all structures to be defined and we do not allow new definitions.

* Fix previous commit
2022-10-18 11:09:00 +02:00
Alexandre Paillier 3e3da4c814 Minimize duplicated code in cross devices settings UX flow 2022-10-17 11:57:17 +02:00
Alexandre Paillier c803322f3c Review fixes 2022-10-17 11:57:16 +02:00
Alexandre Paillier d297a66951 Enforce proper memory alignment on APDU buffer for response status words 2022-10-17 11:57:16 +02:00
Alexandre Paillier fe3f61c7a0 Updated changelog 2022-10-17 11:57:10 +02:00
Alexandre Paillier 2474bdb81a Merge remote-tracking branch 'origin/develop' into HEAD 2022-10-17 11:44:28 +02:00
apaillier-ledgerandGitHub 17665478d9 Merge pull request #354 from LedgerHQ/apr/version_bump
Version bump to 1.10.0
2022-10-14 18:20:55 +02:00
Alexandre Paillier d2659ed332 Version bump to 1.10.0 2022-10-14 17:42:20 +02:00
cbouvet-ledgerandGitHub 75b2b7b850 Merge pull request #353 from LedgerHQ/cbo-stark-utils
move some stack utility functions to common
2022-10-14 12:01:40 +02:00
Clement Bouvet 51e4ab2a6f move some stack utility functions to common 2022-10-14 11:02:11 +02:00
cbouvet-ledgerandGitHub 93ff399fb5 Merge pull request #352 from LedgerHQ/cbo-plugins-common
commonise plugins
2022-10-14 10:54:52 +02:00
Clement Bouvet 2dd757786d commonise plugins 2022-10-14 10:40:00 +02:00
apaillier-ledgerandGitHub a78ca5bce5 Merge pull request #351 from LedgerHQ/develop
App release 1.9.20
2022-10-11 10:24:40 +02:00