Commit Graph
1106 Commits
Author SHA1 Message Date
Jorge MartinsandGitHub 0b288cd924 Eip712 review (#355)
* Possible security fix.

It is possible to send a new structure definition after sending a structure implementation, which makes the app treat unrestricted data as if it was a well defined structure.
This commit tries to fix that behaviour. Once a structure implementation is sent, we consider all structures to be defined and we do not allow new definitions.

* Fix previous commit
2022-10-18 11:09:00 +02:00
Alexandre Paillier 3e3da4c814 Minimize duplicated code in cross devices settings UX flow 2022-10-17 11:57:17 +02:00
Alexandre Paillier c803322f3c Review fixes 2022-10-17 11:57:16 +02:00
Alexandre Paillier d297a66951 Enforce proper memory alignment on APDU buffer for response status words 2022-10-17 11:57:16 +02:00
Alexandre Paillier fe3f61c7a0 Updated changelog 2022-10-17 11:57:10 +02:00
Alexandre Paillier 2474bdb81a Merge remote-tracking branch 'origin/develop' into HEAD 2022-10-17 11:44:28 +02:00
apaillier-ledgerandGitHub 17665478d9 Merge pull request #354 from LedgerHQ/apr/version_bump
Version bump to 1.10.0
2022-10-14 18:20:55 +02:00
Alexandre Paillier d2659ed332 Version bump to 1.10.0 2022-10-14 17:42:20 +02:00
cbouvet-ledgerandGitHub 75b2b7b850 Merge pull request #353 from LedgerHQ/cbo-stark-utils
move some stack utility functions to common
2022-10-14 12:01:40 +02:00
Clement Bouvet 51e4ab2a6f move some stack utility functions to common 2022-10-14 11:02:11 +02:00
cbouvet-ledgerandGitHub 93ff399fb5 Merge pull request #352 from LedgerHQ/cbo-plugins-common
commonise plugins
2022-10-14 10:54:52 +02:00
Clement Bouvet 2dd757786d commonise plugins 2022-10-14 10:40:00 +02:00
apaillier-ledgerandGitHub a78ca5bce5 Merge pull request #351 from LedgerHQ/develop
App release 1.9.20
2022-10-11 10:24:40 +02:00
apaillier-ledgerandGitHub 3c73234cb8 Merge pull request #350 from LedgerHQ/apr/release_changelog
Changelog update & non-dev version number
2022-10-10 15:39:11 +02:00
Alexandre Paillier e34a9f55e9 Changelog update + removed -dev version suffix 2022-10-10 15:18:45 +02:00
apaillier-ledgerandGitHub d0ae7b5cd7 Merge pull request #349 from LedgerHQ/fix-swap-variant
fix: allow swap feature on all ETH variants
2022-10-10 15:07:34 +02:00
Alexandre Paillier 3da1e2fd86 Updated changelog 2022-10-10 14:56:58 +02:00
Edouard Merle c09e17a3e8 fix: allow swap feature on all ETH variants 2022-10-10 14:43:40 +02:00
Jorge MartinsandGitHub fa44edaeeb Merge pull request #348 from LedgerHQ/plugin-error-handling
Abort signing process ETH_PLUGIN_QUERY_*
2022-10-07 17:11:04 +02:00
Jorge Martins 4c78d485a1 Abort signing process ETH_PLUGIN_QUERY_*
Before was not possible to abort the signing process even if the plugin
return an error code. According to the docs any return code besides
ETH_PLUGIN_RESULT_OK should abort the signing process.
2022-10-07 16:40:27 +02:00
apaillier-ledgerandGitHub 8034e269fb Merge pull request #347 from LedgerHQ/apr/feature/eip191_ui_split
Fix EIP-191 UI split + changelog update
2022-10-06 15:41:39 +02:00
Alexandre Paillier f43d9c4dc7 Fix EIP-191 UI split 2022-10-06 15:11:30 +02:00
Alexandre Paillier 82299217de Fix EIP-191 changelog
Wasn't in line with the latest modifications
2022-10-06 15:10:25 +02:00
apaillier-ledgerandGitHub 50e079813e Merge pull request #346 from LedgerHQ/apr/feature/full_eip191_lns
Activate full EIP-191 implementation on LNS
2022-10-04 16:05:06 +02:00
Alexandre Paillier d78bece8d2 Fix Zemu tests 2022-10-04 14:27:22 +02:00
Alexandre Paillier e9ecf2e109 Activate full EIP-191 implementation on LNS + with adequate wording 2022-10-04 13:59:50 +02:00
apaillier-ledgerandGitHub eaeb7cb4c2 Merge pull request #345 from LedgerHQ/purge/compound_plugin
[clean] Removing compound-related plugin code
2022-10-03 15:45:46 +02:00
Lucas PASCALandAlexandre Paillier 3ff15a16e3 [clean] Removing compound-related plugin code 2022-10-03 14:49:54 +02:00
lpascal-ledgerandGitHub d839c35d2e Merge pull request #342 from LedgerHQ/update/changelog
Update changelog for 1.9.20
2022-09-20 11:28:45 +02:00
Lucas PASCAL 1e3083a6f9 Update changelog for 1.9.20 2022-09-19 17:05:35 +02:00
lpascal-ledgerandGitHub 8f1c3f91a7 Merge pull request #339 from LedgerHQ/apr/feature/eip191_full_length
EIP-191 UI improvements
2022-09-19 17:01:20 +02:00
Lucas PASCAL 3f294f9582 Minor fixes after review 2022-09-16 14:43:51 +02:00
Alexandre Paillier 0769eaa651 Updated changelog 2022-09-15 17:11:22 +02:00
Alexandre Paillier 29476ccf99 Proper UI wording on EIP-191 continue/skip screen 2022-09-15 17:11:22 +02:00
Alexandre Paillier ba34e37bce Downgrade to make the app fit on LNS 2022-09-15 16:49:20 +02:00
Alexandre Paillier 971a02dfcf Code space optimization (192 bytes) 2022-09-15 16:49:20 +02:00
Alexandre Paillier 9fc45a7ade Updated EIP-191 Zemu tests 2022-09-15 16:49:20 +02:00
Alexandre Paillier 50dd4f5965 Linting + updated to clang-format 12.0.1 2022-09-15 16:49:19 +02:00
Alexandre Paillier 218098efe9 Removed unused header includes from EIP-191 2022-09-15 16:49:19 +02:00
Alexandre Paillier eec44e994a Removed duplicated function signature of ui_idle 2022-09-15 16:49:19 +02:00
Alexandre Paillier f46ed72c60 Reimplement the status words for EIP-191 error cases without throwing 2022-09-15 16:49:18 +02:00
Alexandre Paillier e93d82c104 Better separation between EIP-191 UI & business logic 2022-09-15 16:49:18 +02:00
Alexandre Paillier 4bbc142ee5 Doxygen comments 2022-09-15 16:49:15 +02:00
Alexandre Paillier 78c0bfe424 Removed EIP-712 strict chain ID check 2022-09-15 16:44:19 +02:00
Alexandre Paillier 40f00bb012 Minimize the RAM used by EIP-191 global variables 2022-09-15 13:25:10 +02:00
Alexandre Paillier aedf6026c7 Handling of EIP191 non ASCII messages 2022-09-15 13:25:09 +02:00
Alexandre Paillier 81e15e51e8 Fix skip issue 2022-09-15 13:25:09 +02:00
Alexandre Paillier 493ce85c3b New implementation 2022-09-15 13:25:08 +02:00
Alexandre Paillier 35c77ff29c Increased EIP712 max array depth to 8 2022-09-14 17:27:34 +02:00
Alexandre Paillier edac57df06 Increased memory allocator pool to 8K 2022-09-14 17:27:33 +02:00