d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Port message review to 'nbgl_useCaseReviewStreamingXXX' in ui_sign_message.c

Browse Source
This commit is contained in:
Charles-Edouard de la Vergne
2024-05-22 11:00:54 +02:00
committed by Alexandre Paillier
parent aa300c99b8
commit dd082be3d1
1 changed files with 62 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

154
src_nbgl/ui_sign_message.c
View File

@@ -20,9 +20,8 @@ typedef enum {
static e_ui_191_action g_action;
static bool skip_message;
static nbgl_contentTagValue_t pair;
static nbgl_contentTagValueList_t tagValueList;
static uint32_t eip191MessageIdx = 0;
static uint32_t stringsTmpTmpIdx = 0;
@@ -35,125 +34,96 @@ static void sign_message(void) {
io_seproxyhal_touch_signMessage_ok();
}
static bool display_message(nbgl_pageContent_t *content) {
static void ui_191_finish_cb(bool confirm) {
if (confirm) {
nbgl_useCaseReviewStatus(STATUS_TYPE_MESSAGE_SIGNED, sign_message);
} else {
nbgl_useCaseReviewStatus(STATUS_TYPE_MESSAGE_REJECTED, reject_message);
}
}
static void ui_191_skip_cb(void) {
nbgl_useCaseReviewStreamingFinish(TEXT_SIGN_EIP191, ui_191_finish_cb);
}
static void getTagValues(void) {
uint16_t len = 0;
bool reached;
if (g_action == UI_191_ACTION_ADVANCE_IN_MESSAGE) {
strncpy(g_stax_shared_buffer + eip191MessageIdx,
strings.tmp.tmp + stringsTmpTmpIdx,
SHARED_BUFFER_SIZE - eip191MessageIdx);
reached = nbgl_getTextMaxLenInNbLines(LARGE_MEDIUM_FONT,
(char *) g_stax_shared_buffer,
SCREEN_WIDTH - (2 * BORDER_MARGIN),
NB_MAX_LINES_IN_REVIEW,
#if (API_LEVEL == 0 || API_LEVEL >= 14)
&len,
false);
#else
&len);
#endif
strncpy(g_stax_shared_buffer + eip191MessageIdx,
strings.tmp.tmp + stringsTmpTmpIdx,
SHARED_BUFFER_SIZE - eip191MessageIdx);
reached = nbgl_getTextMaxLenInNbLines(LARGE_MEDIUM_FONT,
(char *) g_stax_shared_buffer,
SCREEN_WIDTH - (2 * BORDER_MARGIN),
NB_MAX_LINES_IN_REVIEW,
&len,
false);
stringsTmpTmpIdx = len - eip191MessageIdx;
eip191MessageIdx = len;
g_stax_shared_buffer[eip191MessageIdx] = '\0';
stringsTmpTmpIdx = len - eip191MessageIdx;
eip191MessageIdx = len;
g_stax_shared_buffer[eip191MessageIdx] = '\0';
if (!reached && eip191MessageIdx < SHARED_BUFFER_SIZE) {
stringsTmpTmpIdx = 0;
question_switcher();
if (g_action != UI_191_ACTION_GO_TO_SIGN) {
return false;
}
} else if (reached || eip191MessageIdx == SHARED_BUFFER_SIZE) {
eip191MessageIdx = 0;
}
if (!reached && eip191MessageIdx < SHARED_BUFFER_SIZE) {
stringsTmpTmpIdx = 0;
question_switcher();
} else if (reached || eip191MessageIdx == SHARED_BUFFER_SIZE) {
eip191MessageIdx = 0;
}
pair.value = g_stax_shared_buffer;
pair.item = "Message";
content->type = TAG_VALUE_LIST;
content->tagValueList.nbPairs = 1;
content->tagValueList.pairs = &pair;
content->tagValueList.smallCaseForValue = false;
content->tagValueList.nbMaxLinesForValue = NB_MAX_LINES_IN_REVIEW;
content->tagValueList.wrapping = false;
if ((g_action != UI_191_ACTION_IDLE) && (stringsTmpTmpIdx >= strlen(strings.tmp.tmp))) {
// Fetch the next content to display into strings.tmp.tmp buffer.
stringsTmpTmpIdx = 0;
question_switcher();
}
return true;
tagValueList.nbPairs = 1;
tagValueList.pairs = &pair;
tagValueList.smallCaseForValue = false;
tagValueList.nbMaxLinesForValue = NB_MAX_LINES_IN_REVIEW;
tagValueList.wrapping = false;
}
static bool display_sign(nbgl_pageContent_t *content) {
bool ret = false;
if (g_position != UI_SIGNING_POSITION_SIGN) {
content->type = INFO_LONG_PRESS, content->infoLongPress.icon = &C_Review_64px;
content->infoLongPress.text = TEXT_SIGN_EIP191;
content->infoLongPress.longPressText = SIGN_BUTTON;
g_position = UI_SIGNING_POSITION_SIGN;
ret = true;
}
return ret;
}
static bool nav_callback(uint8_t page, nbgl_pageContent_t *content) {
bool ret = true;
if (page == LAST_PAGE_FOR_REVIEW) { // was skipped
skip_message = true;
skip_rest_of_message();
}
if ((g_action != UI_191_ACTION_GO_TO_SIGN) && (g_position != UI_SIGNING_POSITION_SIGN)) {
if (skip_message) {
// do not refresh when this callback triggers after user validation
ret = false;
} else {
ret = display_message(content);
static void ui_191_data_cb(bool more) {
if (more) {
switch (g_action) {
case UI_191_ACTION_IDLE:
g_action = UI_191_ACTION_ADVANCE_IN_MESSAGE;
__attribute__((fallthrough));
case UI_191_ACTION_ADVANCE_IN_MESSAGE:
getTagValues();
nbgl_useCaseReviewStreamingContinueExt(&tagValueList,
ui_191_data_cb,
ui_191_skip_cb);
break;
case UI_191_ACTION_GO_TO_SIGN:
nbgl_useCaseReviewStreamingFinish(TEXT_SIGN_EIP191, ui_191_finish_cb);
break;
}
} else {
// the last page must contain a long press button
ret = display_sign(content);
ui_191_finish_cb(false);
}
return ret;
}
static void continue_review(void) {
nbgl_useCaseForwardOnlyReview(REJECT_BUTTON, NULL, nav_callback, ui_message_review_choice);
}
void ui_191_start(void) {
g_position = UI_SIGNING_POSITION_START;
skip_message = false;
g_action = UI_191_ACTION_IDLE;
eip191MessageIdx = 0;
stringsTmpTmpIdx = 0;
ui_message_start(TEXT_REVIEW_EIP191, &ui_191_switch_to_message, &sign_message, &reject_message);
nbgl_useCaseReviewStreamingStart(TYPE_MESSAGE | SKIPPABLE_OPERATION,
&C_Review_64px,
TEXT_REVIEW_EIP191,
NULL,
ui_191_data_cb);
}
void ui_191_switch_to_message(void) {
g_position = UI_SIGNING_POSITION_REVIEW;
g_action = UI_191_ACTION_ADVANCE_IN_MESSAGE;
// No question mechanism on Stax:
// Message is already displayed
continue_review();
// Get following part of the message
getTagValues();
}
void ui_191_switch_to_sign(void) {
g_action = UI_191_ACTION_GO_TO_SIGN;
// Next nav_callback callback must display
// the hold to approve screen
if (skip_message) {
continue_review(); // to force screen refresh
}
// Next callback must display the hold to approve screen
}
void ui_191_switch_to_question(void) {
// No question mechanism on Stax:
// Always display the next message chunk.
// No question mechanism on Stax: Always display the next message chunk.
continue_displaying_message();
}