d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #582 from LedgerHQ/feat/apa/remove_eip712_filters_counter_check

Browse Source 
Remove filters counter check at the end of EIP712 flow
This commit is contained in:
apaillier-ledger
2024-05-20 11:59:23 +02:00
committed by GitHub
parent e434173bc3 c17e06b525
commit 3e60474607
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src_features/signMessageEIP712/commands_712.c
View File

@@ -196,10 +196,6 @@ bool handle_eip712_sign(const uint8_t *const apdu_buf) {
sizeof(tmpCtx.messageSigningContext712.messageHash)) ||
(path_get_field() != NULL)) {
apdu_response_code = APDU_RESPONSE_CONDITION_NOT_SATISFIED;
} else if ((ui_712_get_filtering_mode() == EIP712_FILTERING_FULL) &&
(ui_712_remaining_filters() != 0)) {
PRINTF("%d EIP712 filters are missing\n", ui_712_remaining_filters());
apdu_response_code = APDU_RESPONSE_REF_DATA_NOT_FOUND;
} else if (parseBip32(&apdu_buf[OFFSET_CDATA], &length, &tmpCtx.messageSigningContext.bip32) !=
NULL) {
if (!N_storage.verbose_eip712 && (ui_712_get_filtering_mode() == EIP712_FILTERING_BASIC)) {