PR Y: wire EXT-* blocker IDs into orchestrator mock-mode logs #28

Merged
nsatoshi merged 1 commits from devin/1776894844-pr-y-blocker-ids into main 2026-04-22 21:58:57 +00:00

1 Commits

Author SHA1 Message Date
Devin AI
012a61cef5 PR Y: wire EXT-* blocker IDs into orchestrator mock-mode logs
Some checks failed
CI / Frontend Lint (pull_request) Failing after 7s
CI / Frontend Type Check (pull_request) Failing after 6s
CI / Frontend Build (pull_request) Failing after 8s
CI / Frontend E2E Tests (pull_request) Failing after 9s
CI / Orchestrator Build (pull_request) Failing after 7s
CI / Orchestrator Unit Tests (pull_request) Failing after 6s
CI / Orchestrator E2E (Testcontainers) (pull_request) Has been skipped
CI / Contracts Compile (pull_request) Failing after 7s
CI / Contracts Test (pull_request) Failing after 6s
Code Quality / SonarQube Analysis (pull_request) Failing after 20s
Code Quality / Code Quality Checks (pull_request) Failing after 6s
Security Scan / Dependency Vulnerability Scan (pull_request) Failing after 4s
Security Scan / OWASP ZAP Scan (pull_request) Failing after 4s
Mirrors the external-dependency blocker gate added to the proxmox
repo (scripts/verify/check-external-dependencies.sh + docs/03-
deployment/EXTERNAL_DEPENDENCY_BLOCKERS.md) so orchestrator startup
logs and provider-switch mock-mode logs surface the same EXT-* IDs
the deployment pipeline already tracks.

Central registry:

  - src/config/externalBlockers.ts — typed EXT_BLOCKER_IDS union
    (EXT-DBIS-CORE, EXT-CC-PAYMENT-ADAPTERS, EXT-CC-AUDIT-LEDGER,
    EXT-CC-SHARED-EVENTS, EXT-CC-SHARED-SCHEMAS, EXT-FIN-GATEWAY,
    EXT-CHAIN138-CI-RPC), BLOCKER_DETAILS map with per-id resolving
    env var, evaluateBlockers(env) / activeBlockers() / and
    logBlockerStatusAtBoot(logger) for a single-line structured
    startup summary.

Wired sites:

  - src/index.ts — logs the full blocker summary after validateEnv().
  - services/dbisCore/client.ts — mock-mode log now carries
    blockerId: EXT-DBIS-CORE.
  - services/finLink/client.ts — getFinLinkClient() now logs live vs.
    in-process sandbox decisions; sandbox path carries
    blockerId: EXT-FIN-GATEWAY.
  - services/bank.ts — migrated from console.log to pino; mock-mode
    (no DBIS_CORE_URL) carries blockerId: EXT-DBIS-CORE because
    dbis_core is the bank's real back-end.
  - services/completeCredential/identityClient.ts — mock log tagged
    'upstream cc-identity-core ships code but not yet deployed' to
    distinguish 'env not set' from the cc-* scaffold blockers.

Unit tests: tests/config/externalBlockers.test.ts — 11 tests
covering registry shape, evaluation across env permutations (empty
env, each resolving env set, scaffold blockers remain active,
empty-string treated as unset), and log emission.

Full unit suite: 13 suites / 167 tests passing. tsc --noEmit clean.
No UI changes.
2026-04-22 21:54:04 +00:00