d-bis/CurrenciCombo
5
0
Fork 0
Code Issues Pull Requests 9 Actions Packages Projects Releases Wiki Activity

PR W: DBIS Complete Credential (cc-*) adapters with provider-switch #27

Merged
nsatoshi merged 0 commits from devin/1776892271-pr-w-cc-adapters into main 2026-04-22 14:12:23 -07:00
Conversation 0 Commits - Files Changed -
nsatoshi commented 2026-04-22 14:11:31 -07:00
Owner
Copy Link
Copy Source

Summary

Headless client adapters for the DBIS Complete Credential bounded-context repos (DBIS/cc-*) that actually ship runnable code today:

  • cc-identity-core — HTTP service (GET /health, GET /ready, POST /v1/subjects per upstream openapi.yaml / src/server.mjs).
  • cc-compliance-controls — controls/matrix/v0.yaml (loader with embedded v0 snapshot + optional remote JSON override).

Other cc-* repos inspected but not wired — cc-payment-adapters, cc-audit-ledger, cc-shared-events, cc-shared-schemas are template scaffolds upstream at recon time (README: Template scaffold only. Implement per master plan delivery phases…). When those services ship, add sibling clients here following the same provider-switch pattern.

Closes gap-analysis v3 §10 “DBIS cc-* separate repos” external blocker — the CurrenciCombo side is now ready; activation is a 1-env-var flip per adapter when the upstream services deploy.

Provider switch

Adapter Env var Unset behaviour Set behaviour
CcIdentityClient CC_IDENTITY_URL MockCcIdentityClient HttpCcIdentityClient with X-API-Key (CC_IDENTITY_API_KEY), auto-minted X-Correlation-Id, 10s AbortController timeout
loadControlsMatrix() CC_CONTROLS_MATRIX_URL Embedded v0 matrix (hand-typed snapshot) Remote JSON loader, normalises snake_case → camelCase per upstream YAML

Files

  • orchestrator/src/services/completeCredential/types.ts — shared shapes.
  • orchestrator/src/services/completeCredential/identityClient.ts — Http + Mock + factory.
  • orchestrator/src/services/completeCredential/controlsMatrix.ts — embedded v0 + remote loader + findControl() helper.
  • orchestrator/src/services/completeCredential/index.ts — barrel.
  • orchestrator/tests/services/completeCredential.test.ts — 16 tests across 4 describe blocks covering both legs of both adapters.

Verification

  • npx tsc --noEmit clean.
  • npx jest unit suite: 12 suites / 156 tests, all passing (no regressions from PR V landing).
  • No new runtime dependencies.
  • No UI changes. Headless backend only.
## Summary Headless client adapters for the DBIS Complete Credential bounded-context repos (`DBIS/cc-*`) that actually ship runnable code today: - `cc-identity-core` — HTTP service (`GET /health`, `GET /ready`, `POST /v1/subjects` per upstream `openapi.yaml` / `src/server.mjs`). - `cc-compliance-controls` — `controls/matrix/v0.yaml` (loader with embedded v0 snapshot + optional remote JSON override). **Other `cc-*` repos inspected but not wired** — `cc-payment-adapters`, `cc-audit-ledger`, `cc-shared-events`, `cc-shared-schemas` are template scaffolds upstream at recon time (README: `Template scaffold only. Implement per master plan delivery phases…`). When those services ship, add sibling clients here following the same provider-switch pattern. Closes gap-analysis v3 §10 “DBIS cc-* separate repos” external blocker — the CurrenciCombo side is now ready; activation is a 1-env-var flip per adapter when the upstream services deploy. ## Provider switch | Adapter | Env var | Unset behaviour | Set behaviour | |---|---|---|---| | `CcIdentityClient` | `CC_IDENTITY_URL` | `MockCcIdentityClient` | `HttpCcIdentityClient` with `X-API-Key` (`CC_IDENTITY_API_KEY`), auto-minted `X-Correlation-Id`, 10s `AbortController` timeout | | `loadControlsMatrix()` | `CC_CONTROLS_MATRIX_URL` | Embedded v0 matrix (hand-typed snapshot) | Remote JSON loader, normalises snake_case → camelCase per upstream YAML | ## Files - `orchestrator/src/services/completeCredential/types.ts` — shared shapes. - `orchestrator/src/services/completeCredential/identityClient.ts` — Http + Mock + factory. - `orchestrator/src/services/completeCredential/controlsMatrix.ts` — embedded v0 + remote loader + `findControl()` helper. - `orchestrator/src/services/completeCredential/index.ts` — barrel. - `orchestrator/tests/services/completeCredential.test.ts` — 16 tests across 4 describe blocks covering both legs of both adapters. ## Verification - `npx tsc --noEmit` clean. - `npx jest` unit suite: 12 suites / 156 tests, all passing (no regressions from PR V landing). - No new runtime dependencies. - No UI changes. Headless backend only.
nsatoshi merged commit c1aef82ede into main 2026-04-22 14:12:23 -07:00
nsatoshi deleted branch devin/1776892271-pr-w-cc-adapters 2026-04-22 14:12:24 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Bug report or regression
 documentation
Documentation task or copy update
 enhancement
Feature request or UX improvement
 maintenance
Tooling, cleanup, or admin task
 question
Need clarification or investigation
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
70rn4710n (FAFO) A.r.yavari SEG nsatoshi zardashtways44
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: d-bis/CurrenciCombo#27