d-bis/CurrenciCombo
5
0
Fork 0
Code Issues Pull Requests 9 Actions Packages Projects Releases Wiki Activity

PR K: per-state PHASE_TIMEOUTS map + env overrides #15

Open
nsatoshi wants to merge 0 commits from devin/1776881375-pr-k-phase-timeouts into main
pull from: devin/1776881375-pr-k-phase-timeouts
merge into: :main
Conversation 0 Commits - Files Changed -
nsatoshi commented 2026-04-22 11:11:35 -07:00
Owner
Copy Link
Copy Source

Closes gap-analysis v2 §7.6 + §10.7.

  • DEFAULT_PHASE_TIMEOUTS: Record<TransactionState, number | null> covering all 12 states (arch §8) with per-state rationale.
  • getPhaseTimeoutMs(state) honours per-state env overrides PHASE_TIMEOUT_<STATE>=<ms>; 0 disables the watchdog; invalid values fall through to the default.
  • CLOSED is the only state with null (no timeout).
  • 9 unit tests.

Wiring the map into the scheduler / exception manager is out of scope here — this PR lands the policy + env contract only; the watchdog consumer will follow once PR M / PR N land (they touch the same transition path).

Closes gap-analysis v2 §7.6 + §10.7. - `DEFAULT_PHASE_TIMEOUTS: Record<TransactionState, number | null>` covering all 12 states (arch §8) with per-state rationale. - `getPhaseTimeoutMs(state)` honours per-state env overrides `PHASE_TIMEOUT_<STATE>=<ms>`; `0` disables the watchdog; invalid values fall through to the default. - `CLOSED` is the only state with `null` (no timeout). - 9 unit tests. Wiring the map into the scheduler / exception manager is out of scope here — this PR lands the policy + env contract only; the watchdog consumer will follow once PR M / PR N land (they touch the same transition path).
nsatoshi added 1 commit 2026-04-22 11:11:36 -07:00
Per-state PHASE_TIMEOUTS map + env overrides
CI / Frontend Lint (pull_request) Failing after 6s
Details
CI / Frontend Type Check (pull_request) Failing after 7s
Details
CI / Frontend Build (pull_request) Failing after 6s
Details
CI / Frontend E2E Tests (pull_request) Failing after 8s
Details
CI / Orchestrator Build (pull_request) Failing after 6s
Details
CI / Contracts Compile (pull_request) Failing after 6s
Details
CI / Contracts Test (pull_request) Failing after 7s
Details
Code Quality / SonarQube Analysis (pull_request) Failing after 20s
Details
Code Quality / Code Quality Checks (pull_request) Failing after 6s
Details
Security Scan / Dependency Vulnerability Scan (pull_request) Failing after 4s
Details
Security Scan / OWASP ZAP Scan (pull_request) Failing after 4s
Details
e3328725b4 
Closes gap-analysis v2 §7.6 / §10.7.

- Adds DEFAULT_PHASE_TIMEOUTS: Record<TransactionState, number | null>
  to orchestrator/src/types/transactionState.ts, covering all 12 states
  of the §8 state machine with rationale-per-state comments.
- getPhaseTimeoutMs(state) honours per-state env overrides
  (PHASE_TIMEOUT_<STATE>=<ms>; '0' disables; invalid → default).
- CLOSED is the only state with a null (no-timeout) value.
- 9 unit tests; full suite passes.
This pull request is broken due to missing fork information.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin devin/1776881375-pr-k-phase-timeouts:devin/1776881375-pr-k-phase-timeouts
git checkout devin/1776881375-pr-k-phase-timeouts
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Bug report or regression
 documentation
Documentation task or copy update
 enhancement
Feature request or UX improvement
 maintenance
Tooling, cleanup, or admin task
 question
Need clarification or investigation
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
70rn4710n (FAFO) A.r.yavari SEG nsatoshi zardashtways44
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: d-bis/CurrenciCombo#15