From 1ce8558df47186bcba5ee8564fdb04583bf115dd Mon Sep 17 00:00:00 2001 From: iketw <121973632+iketw@users.noreply.github.com> Date: Wed, 21 Jun 2023 12:28:16 -0400 Subject: [PATCH] [Wallets] Fix switchChain in WCV2 connector (#1214) --- .changeset/old-spoons-do.md | 7 +++++++ .../wallets/src/evm/connectors/wallet-connect/index.ts | 8 +++++--- 2 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 .changeset/old-spoons-do.md diff --git a/.changeset/old-spoons-do.md b/.changeset/old-spoons-do.md new file mode 100644 index 000000000..9e819bcd5 --- /dev/null +++ b/.changeset/old-spoons-do.md @@ -0,0 +1,7 @@ +--- +"@thirdweb-dev/wallets": patch +--- + +[Wallets] Fix switchChain in WCV2 connector + +WCV2 `blockExplorerUrls` field receives an array of urls but we were passing an array of blockExplorer objects, so adding a new chain was failing, hence switching chains was failing diff --git a/packages/wallets/src/evm/connectors/wallet-connect/index.ts b/packages/wallets/src/evm/connectors/wallet-connect/index.ts index 9628bebd2..38018dfe8 100644 --- a/packages/wallets/src/evm/connectors/wallet-connect/index.ts +++ b/packages/wallets/src/evm/connectors/wallet-connect/index.ts @@ -250,17 +250,18 @@ export class WalletConnectConnector extends WagmiConnector< const isChainApproved = namespaceChains.includes(chainId); if (!isChainApproved && namespaceMethods.includes(ADD_ETH_CHAIN_METHOD)) { + const blockExplorerUrls = chain.explorers?.length + ? { blockExplorerUrls: [chain.explorers[0].url] } + : {}; await provider.request({ method: ADD_ETH_CHAIN_METHOD, params: [ { chainId: utils.hexValue(chain.chainId), - blockExplorerUrls: [ - chain.explorers?.length ? chain.explorers[0] : undefined, - ], chainName: chain.name, nativeCurrency: chain.nativeCurrency, rpcUrls: [...chain.rpc], + ...blockExplorerUrls, }, ], }); @@ -282,6 +283,7 @@ export class WalletConnectConnector extends WagmiConnector< if (/user rejected request/i.test(message)) { throw new UserRejectedRequestError(error); } + throw new SwitchChainError(error); } }