[Refactor] Update EngineNavigation with useCallback and useMemo, clean up imports (#3436)
This pull request focuses on refactoring the engine navigation and sidebar integration in the dashboard app.
### What changed?
- Refactored the `EngineNavigation` component to replace the tab-based navigation with a sidebar-based navigation using `SidebarNav` from `core-ui`.
- Removed the old `EngineSidebar` component as it is no longer needed.
- Adjusted the `BasisPointsInput` component to fix ESLint issues.
- Updated various files to improve consistency and address minor code quality issues.
### How to test?
1. Navigate to the engine section of the dashboard.
2. Verify that the new sidebar navigation works as expected.
3. Test the `BasisPointsInput` component to ensure it is functioning correctly.
4. Run the codebase through a linting tool to ensure no new linting issues have been introduced.
### Why make this change?
This refactor aims to enhance the user experience by providing a more intuitive navigation system and to improve the maintainability of the code.
---
<!-- start pr-codex -->
---
## PR-Codex overview
This PR enhances the sidebar navigation in the dashboard by adding `onClick` functionality to sidebar links and updating the engine navigation component.
### Detailed summary
- Added `onClick` functionality to sidebar links in the dashboard
- Updated the engine navigation component with new functionalities and optimizations
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
This commit is contained in:
+11
-12
@@ -11,25 +11,24 @@
|
||||
},
|
||||
"scripts": {
|
||||
"preinstall": "npx only-allow pnpm",
|
||||
"lint": "turbo run lint",
|
||||
"lint:legacy": "pnpm lint",
|
||||
"fix": "turbo run fix",
|
||||
"playground": "turbo run dev --filter=./apps/playground-web --filter=./packages/thirdweb",
|
||||
"playground:build": "turbo run build --filter=./apps/playground-web",
|
||||
"dashboard": "turbo run dev --filter=./apps/dashboard --filter=./packages/thirdweb",
|
||||
"dashboard:build": "turbo run build --filter=./apps/dashboard",
|
||||
"build:packages": "turbo run build --filter=./packages/*",
|
||||
"build:legacy_packages": "turbo run build --filter=./legacy_packages/*",
|
||||
"build": "turbo run build --filter=./packages/* --filter=./legacy_packages/*",
|
||||
"build:release": "pnpm run build --force",
|
||||
"test": "turbo run test --filter=./packages/*",
|
||||
"test:legacy": "turbo run test --filter=./legacy_packages/* --filter=!@thirdweb-dev/sdk --filter=!@thirdweb-dev/auth",
|
||||
"e2e": "turbo run e2e --filter=./packages/*",
|
||||
"e2e:legacy": "turbo run e2e --filter=./legacy_packages/*",
|
||||
"build:packages": "turbo run build --filter=./packages/*",
|
||||
"build:legacy_packages": "turbo run build --filter=./legacy_packages/*",
|
||||
"build": "turbo run build --filter=./packages/* --filter=./legacy_packages/*",
|
||||
"bench": "turbo run bench",
|
||||
"typedoc": "turbo run typedoc",
|
||||
"generate-snippets": "node ./scripts/generate-snippets/index.mjs",
|
||||
"build:release": "pnpm run build --force",
|
||||
"dev:playground": "turbo run dev --no-cache --parallel --continue --filter=!./apps/dashboard",
|
||||
"dev:dashboard": "turbo run dev --filter=./apps/dashboard --filter=./packages/thirdweb",
|
||||
"build:dashboard": "turbo run build --filter=./apps/dashboard",
|
||||
"fix:repo": "manypkg fix",
|
||||
"lint": "turbo run lint --filter=./packages/*",
|
||||
"lint:legacy": "turbo run lint --filter=./legacy_packages/*",
|
||||
"fix": "turbo run fix",
|
||||
"clean": "turbo run clean && rm -rf node_modules",
|
||||
"changeset": "changeset",
|
||||
"version-packages": "changeset version",
|
||||
"release": "node ./scripts/pre-release.mjs && turbo run update-version && pnpm build && changeset publish",
|
||||
|
||||
Reference in New Issue
Block a user