d-bis/dodo-contractV2
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[audit]#11 check balance when transfer in/out

Browse Source
This commit is contained in:
mingda
2020-07-10 13:35:10 +08:00
parent 7adec98a1d
commit cae14bde20
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
contracts/impl/Settlement.sol
View File

@@ -36,23 +36,31 @@ contract Settlement is Storage {
// ============ Assets IN/OUT Functions ============ // ============ Assets IN/OUT Functions ============
function _baseTokenTransferIn(address from, uint256 amount) internal { function _baseTokenTransferIn(address from, uint256 amount) internal {
uint256 beforeBalance = IERC20(_BASE_TOKEN_).balanceOf(address(this));
IERC20(_BASE_TOKEN_).safeTransferFrom(from, address(this), amount); IERC20(_BASE_TOKEN_).safeTransferFrom(from, address(this), amount);
_BASE_BALANCE_ = _BASE_BALANCE_.add(amount); uint256 afterBalance = IERC20(_BASE_TOKEN_).balanceOf(address(this));
_BASE_BALANCE_ = _BASE_BALANCE_.add(afterBalance.sub(beforeBalance));
} }
function _quoteTokenTransferIn(address from, uint256 amount) internal { function _quoteTokenTransferIn(address from, uint256 amount) internal {
uint256 beforeBalance = IERC20(_QUOTE_TOKEN_).balanceOf(address(this));
IERC20(_QUOTE_TOKEN_).safeTransferFrom(from, address(this), amount); IERC20(_QUOTE_TOKEN_).safeTransferFrom(from, address(this), amount);
_QUOTE_BALANCE_ = _QUOTE_BALANCE_.add(amount); uint256 afterBalance = IERC20(_QUOTE_TOKEN_).balanceOf(address(this));
_QUOTE_BALANCE_ = _QUOTE_BALANCE_.add(afterBalance.sub(beforeBalance));
} }
function _baseTokenTransferOut(address to, uint256 amount) internal { function _baseTokenTransferOut(address to, uint256 amount) internal {
uint256 beforeBalance = IERC20(_BASE_TOKEN_).balanceOf(address(this));
IERC20(_BASE_TOKEN_).safeTransfer(to, amount); IERC20(_BASE_TOKEN_).safeTransfer(to, amount);
_BASE_BALANCE_ = _BASE_BALANCE_.sub(amount); uint256 afterBalance = IERC20(_BASE_TOKEN_).balanceOf(address(this));
_BASE_BALANCE_ = _BASE_BALANCE_.sub(beforeBalance.sub(afterBalance));
} }
function _quoteTokenTransferOut(address to, uint256 amount) internal { function _quoteTokenTransferOut(address to, uint256 amount) internal {
uint256 beforeBalance = IERC20(_QUOTE_TOKEN_).balanceOf(address(this));
IERC20(_QUOTE_TOKEN_).safeTransfer(to, amount); IERC20(_QUOTE_TOKEN_).safeTransfer(to, amount);
_QUOTE_BALANCE_ = _QUOTE_BALANCE_.sub(amount); uint256 afterBalance = IERC20(_QUOTE_TOKEN_).balanceOf(address(this));
_QUOTE_BALANCE_ = _QUOTE_BALANCE_.sub(beforeBalance.sub(afterBalance));
} }
// ============ Donate to Liquidity Pool Functions ============ // ============ Donate to Liquidity Pool Functions ============