Fix pylint issues

This commit is contained in:
Charles-Edouard de la Vergne
2024-03-26 09:43:26 +01:00
parent 565c6fab66
commit fa3e87a06c
8 changed files with 134 additions and 138 deletions

View File

@@ -1,30 +1,32 @@
import pytest
from typing import Optional
import pytest
from ledger_app_clients.ethereum.client import EthAppClient, StatusWord
import ledger_app_clients.ethereum.response_parser as ResponseParser
from ragger.error import ExceptionRAPDU
from ragger.firmware import Firmware
from ragger.backend import BackendInterface
from ragger.navigator import Navigator, NavInsID
from ledger_app_clients.ethereum.client import EthAppClient, StatusWord
import ledger_app_clients.ethereum.response_parser as ResponseParser
from ragger.bip import calculate_public_key_and_chaincode, CurveChoice
from constants import ROOT_SNAPSHOT_PATH
@pytest.fixture(params=[True, False])
def with_chaincode(request) -> bool:
@pytest.fixture(name="with_chaincode", params=[True, False])
def with_chaincode_fixture(request) -> bool:
return request.param
@pytest.fixture(params=[None, 1, 2, 5, 137])
def chain(request) -> Optional[int]:
@pytest.fixture(name="chain", params=[None, 1, 2, 5, 137])
def chain_fixture(request) -> Optional[int]:
return request.param
def get_moves(firmware: Firmware,
navigator: BackendInterface,
chain: Optional[int] = None,
reject: bool = False):
moves = list()
moves = []
if firmware.is_nano:
moves += [NavInsID.RIGHT_CLICK]
@@ -56,7 +58,7 @@ def test_get_pk_rejected(firmware: Firmware,
with app_client.get_public_addr():
navigator.navigate_and_compare(ROOT_SNAPSHOT_PATH,
"get_pk_rejected",
get_moves(firmware, navigator, reject=True))
get_moves(firmware, reject=True))
assert e.value.status == StatusWord.CONDITION_NOT_SATISFIED
@@ -69,9 +71,9 @@ def test_get_pk(firmware: Firmware,
with app_client.get_public_addr(chaincode=with_chaincode, chain_id=chain):
navigator.navigate_and_compare(ROOT_SNAPSHOT_PATH,
"get_pk_%s" % (chain),
get_moves(firmware, navigator, chain=chain))
pk, addr, chaincode = ResponseParser.pk_addr(app_client.response().data, with_chaincode)
f"get_pk_{chain}",
get_moves(firmware, chain=chain))
pk, _, chaincode = ResponseParser.pk_addr(app_client.response().data, with_chaincode)
ref_pk, ref_chaincode = calculate_public_key_and_chaincode(curve=CurveChoice.Secp256k1,
path="m/44'/60'/0'/0/0")
assert pk.hex() == ref_pk