d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pylint issues

Browse Source
This commit is contained in:
Charles-Edouard de la Vergne
2024-03-26 09:43:26 +01:00
parent 565c6fab66
commit fa3e87a06c
8 changed files with 134 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
tests/ragger/test_domain_name.py
View File

@@ -1,15 +1,15 @@
import pytest
from ragger.backend import BackendInterface
from ragger.firmware import Firmware
from ragger.error import ExceptionRAPDU
from ragger.navigator import Navigator, NavInsID
from constants import ROOT_SNAPSHOT_PATH
from web3 import Web3
import ledger_app_clients.ethereum.response_parser as ResponseParser
from ledger_app_clients.ethereum.client import EthAppClient, StatusWord
from ledger_app_clients.ethereum.settings import SettingID, settings_toggle
from ragger.backend import BackendInterface
from ragger.firmware import Firmware
from ragger.error import ExceptionRAPDU
from ragger.navigator import Navigator, NavInsID
from web3 import Web3
from constants import ROOT_SNAPSHOT_PATH
# Values used across all tests
@@ -25,13 +25,14 @@ GAS_LIMIT = 21000
AMOUNT = 1.22
@pytest.fixture(params=[False, True])
def verbose(request) -> bool:
@pytest.fixture(name="verbose", params=[False, True])
def verbose_fixture(request) -> bool:
return request.param
def common(app_client: EthAppClient) -> int:
if app_client._client.firmware.device == "nanos":
def common(firmware: Firmware, app_client: EthAppClient) -> int:
if firmware.device == "nanos":
pytest.skip("Not supported on LNS")
challenge = app_client.get_challenge()
return ResponseParser.challenge(challenge.data)
@@ -40,10 +41,9 @@ def common(app_client: EthAppClient) -> int:
def test_send_fund(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator,
test_name: str,
verbose: bool):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
if verbose:
settings_toggle(firmware, navigator, [SettingID.VERBOSE_ENS])
@@ -59,7 +59,7 @@ def test_send_fund(firmware: Firmware,
"value": Web3.to_wei(AMOUNT, "ether"),
"chainId": CHAIN_ID
}):
moves = list()
moves = []
if firmware.device.startswith("nano"):
moves += [NavInsID.RIGHT_CLICK] * 4
if verbose:
@@ -75,11 +75,9 @@ def test_send_fund(firmware: Firmware,
moves)
def test_send_fund_wrong_challenge(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator):
def test_send_fund_wrong_challenge(firmware: Firmware, backend: BackendInterface):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
with pytest.raises(ExceptionRAPDU) as e:
app_client.provide_domain_name(~challenge & 0xffffffff, NAME, ADDR)
@@ -88,10 +86,9 @@ def test_send_fund_wrong_challenge(firmware: Firmware,
def test_send_fund_wrong_addr(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator,
test_name: str):
navigator: Navigator):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
app_client.provide_domain_name(challenge, NAME, ADDR)
@@ -107,7 +104,7 @@ def test_send_fund_wrong_addr(firmware: Firmware,
"value": Web3.to_wei(AMOUNT, "ether"),
"chainId": CHAIN_ID
}):
moves = list()
moves = []
if firmware.device.startswith("nano"):
moves += [NavInsID.RIGHT_CLICK] * 4
moves += [NavInsID.BOTH_CLICK]
@@ -121,10 +118,9 @@ def test_send_fund_wrong_addr(firmware: Firmware,
def test_send_fund_non_mainnet(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator,
test_name: str):
navigator: Navigator):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
app_client.provide_domain_name(challenge, NAME, ADDR)
@@ -137,7 +133,7 @@ def test_send_fund_non_mainnet(firmware: Firmware,
"value": Web3.to_wei(AMOUNT, "ether"),
"chainId": 5
}):
moves = list()
moves = []
if firmware.device.startswith("nano"):
moves += [NavInsID.RIGHT_CLICK] * 5
moves += [NavInsID.BOTH_CLICK]
@@ -151,10 +147,9 @@ def test_send_fund_non_mainnet(firmware: Firmware,
def test_send_fund_unknown_chain(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator,
test_name: str):
navigator: Navigator):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
app_client.provide_domain_name(challenge, NAME, ADDR)
@@ -167,7 +162,7 @@ def test_send_fund_unknown_chain(firmware: Firmware,
"value": Web3.to_wei(AMOUNT, "ether"),
"chainId": 9
}):
moves = list()
moves = []
if firmware.device.startswith("nano"):
moves += [NavInsID.RIGHT_CLICK] * 5
moves += [NavInsID.BOTH_CLICK]
@@ -179,44 +174,36 @@ def test_send_fund_unknown_chain(firmware: Firmware,
moves)
def test_send_fund_domain_too_long(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator):
def test_send_fund_domain_too_long(firmware: Firmware, backend: BackendInterface):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
with pytest.raises(ExceptionRAPDU) as e:
app_client.provide_domain_name(challenge, "ledger" + "0"*25 + ".eth", ADDR)
assert e.value.status == StatusWord.INVALID_DATA
def test_send_fund_domain_invalid_character(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator):
def test_send_fund_domain_invalid_character(firmware: Firmware, backend: BackendInterface):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
with pytest.raises(ExceptionRAPDU) as e:
app_client.provide_domain_name(challenge, "l\xe8dger.eth", ADDR)
assert e.value.status == StatusWord.INVALID_DATA
def test_send_fund_uppercase(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator):
def test_send_fund_uppercase(firmware: Firmware, backend: BackendInterface):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
with pytest.raises(ExceptionRAPDU) as e:
app_client.provide_domain_name(challenge, NAME.upper(), ADDR)
assert e.value.status == StatusWord.INVALID_DATA
def test_send_fund_domain_non_ens(firmware: Firmware,
backend: BackendInterface,
navigator: Navigator):
def test_send_fund_domain_non_ens(firmware: Firmware, backend: BackendInterface):
app_client = EthAppClient(backend)
challenge = common(app_client)
challenge = common(firmware, app_client)
with pytest.raises(ExceptionRAPDU) as e:
app_client.provide_domain_name(challenge, "ledger.hte", ADDR)