d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix V computing when using < 4 bytes chain IDs

Browse Source
This commit is contained in:
pscott
2021-08-27 18:35:53 +02:00
parent 1b07cf2861
commit dda1e20fb3
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src_features/signTx/ui_common_signTx.c
View File

@@ -41,9 +41,10 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
// New API // New API
// Note that this is wrong for a large v, but ledgerjs will recover. // Note that this is wrong for a large v, but ledgerjs will recover.
// Casting to u32 not to introduce breaking changes. In the future, this should be // Taking only the 4 highest bytes to not introduce breaking changes. In the future,
// updated. // this should be updated.
uint32_t v = U4BE(tmpContent.txContent.v, 0); uint32_t v = (uint32_t) u64_from_BE(tmpContent.txContent.v,
MIN(4, tmpContent.txContent.vLength));
G_io_apdu_buffer[0] = (v * 2) + 35; G_io_apdu_buffer[0] = (v * 2) + 35;
} }
if (info & CX_ECCINFO_PARITY_ODD) { if (info & CX_ECCINFO_PARITY_ODD) {