d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #510 from LedgerHQ/fix/apa/standard_plugin_variant

Browse Source 
Fix standard plugin variant + null-check on parameters
This commit is contained in:
apaillier-ledger
2023-12-07 16:52:40 +01:00
committed by GitHub
parent 0c263ca2b5 cce38525a0
commit 97f17b28cf
3 changed files with 30 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src_plugin_sdk/CHANGELOG.md
View File

@@ -5,11 +5,13 @@
| :rotating_light: | Breaks build | | :rotating_light: | Breaks build |
| :warning: | Breaks compatibility with app | | :warning: | Breaks compatibility with app |
## [latest](/) - 2023/12/06 ## [latest](/) - 2023/12/07
### Fixed ### Fixed
* standard\_plugin build ([this PR on the SDK](https://github.com/LedgerHQ/ledger-secure-sdk/pull/473) had broken it) * standard\_plugin build ([this PR on the SDK](https://github.com/LedgerHQ/ledger-secure-sdk/pull/473) had broken it)
* Broken variant auto-setting in the standard\_plugin Makefile
* Missing null-check on parameters received by the plugins
### Changed ### Changed

48
src_plugin_sdk/main.c
View File

@@ -53,28 +53,32 @@ static void call_app_ethereum() {
// Function to dispatch calls from the ethereum app. // Function to dispatch calls from the ethereum app.
static void dispatch_call(int message, void *parameters) { static void dispatch_call(int message, void *parameters) {
switch (message) { if (parameters != NULL) {
case ETH_PLUGIN_INIT_CONTRACT: switch (message) {
handle_init_contract(parameters); case ETH_PLUGIN_INIT_CONTRACT:
break; handle_init_contract(parameters);
case ETH_PLUGIN_PROVIDE_PARAMETER: break;
handle_provide_parameter(parameters); case ETH_PLUGIN_PROVIDE_PARAMETER:
break; handle_provide_parameter(parameters);
case ETH_PLUGIN_FINALIZE: break;
handle_finalize(parameters); case ETH_PLUGIN_FINALIZE:
break; handle_finalize(parameters);
case ETH_PLUGIN_PROVIDE_INFO: break;
handle_provide_token(parameters); case ETH_PLUGIN_PROVIDE_INFO:
break; handle_provide_token(parameters);
case ETH_PLUGIN_QUERY_CONTRACT_ID: break;
handle_query_contract_id(parameters); case ETH_PLUGIN_QUERY_CONTRACT_ID:
break; handle_query_contract_id(parameters);
case ETH_PLUGIN_QUERY_CONTRACT_UI: break;
handle_query_contract_ui(parameters); case ETH_PLUGIN_QUERY_CONTRACT_UI:
break; handle_query_contract_ui(parameters);
default: break;
PRINTF("Unhandled message %d\n", message); default:
break; PRINTF("Unhandled message %d\n", message);
break;
}
} else {
PRINTF("Received null parameters\n");
} }
} }

2
src_plugin_sdk/standard_plugin.mk
View File

@@ -48,7 +48,7 @@ CURVE_APP_LOAD_PARAMS = secp256k1
PATH_APP_LOAD_PARAMS ?= "44'/60'" PATH_APP_LOAD_PARAMS ?= "44'/60'"
VARIANT_PARAM = COIN VARIANT_PARAM = COIN
VARIANTS_VALUES ?= $(NORMAL_NAME) VARIANT_VALUES ?= $(NORMAL_NAME)
HAVE_APPLICATION_FLAG_LIBRARY = 1 HAVE_APPLICATION_FLAG_LIBRARY = 1