Merge pull request #347 from LedgerHQ/apr/feature/eip191_ui_split

Fix EIP-191 UI split + changelog update

CHANGELOG.md

@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [1.9.20](https://github.com/ledgerhq/app-ethereum/compare/1.9.19...1.9.20) - 2022-09-19
+## [1.9.20](https://github.com/ledgerhq/app-ethereum/compare/1.9.19...1.9.20) - 2022-XX-XX
 
 ### Added
 
@@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
-- EIP-191 improvements, now lets the user see the entire message by chunks 255 characters (LNX & LNS+), LNS still limited to the first chunk of 99 characters
+- EIP-191 improvements, now lets the user see the entire message one chunk at a time (255 characters for LNX & LNS+, 99 for LNS)
 
 ## [1.9.19](https://github.com/ledgerhq/app-ethereum/compare/1.9.18...1.9.19) - 2022-06-15
 

src/common_ui.h

@@ -18,6 +18,13 @@ void ui_stark_limit_order(void);
 void ui_stark_unsafe_sign(void);
 void ui_stark_transfer(bool selfTransfer, bool conditional);
 
+// EIP-191
+void ui_191_start(void);
+void ui_191_switch_to_message(void);
+void ui_191_switch_to_message_end(void);
+void ui_191_switch_to_sign(void);
+void ui_191_switch_to_question(void);
+
 #include "ui_callbacks.h"
 #include <string.h>
 

src_bagl/ui_flow_signMessage.c

@@ -1,8 +1,10 @@
 #include "shared_context.h"
 #include "ui_callbacks.h"
-#include "ui_flow_signMessage.h"
+#include "common_ui.h"
 #include "sign_message.h"
 
+typedef enum { UI_191_POS_REVIEW, UI_191_POS_QUESTION, UI_191_POS_END } e_ui_191_position;
+
 static uint8_t ui_pos;
 
 static void dummy_pre_cb(void) {

src_bagl/ui_flow_signMessage.h

@@ -1,12 +0,0 @@
-#ifndef UI_FLOW_SIGNMESSAGE_H_
-#define UI_FLOW_SIGNMESSAGE_H_
-
-typedef enum { UI_191_POS_REVIEW, UI_191_POS_QUESTION, UI_191_POS_END } e_ui_191_position;
-
-void ui_191_start(void);
-void ui_191_switch_to_message(void);
-void ui_191_switch_to_message_end(void);
-void ui_191_switch_to_sign(void);
-void ui_191_switch_to_question(void);
-
-#endif  // UI_FLOW_SIGNMESSAGE_H_

src_features/signMessage/cmd_signMessage.c

@@ -3,7 +3,7 @@
 #include <string.h>
 #include "apdu_constants.h"
 #include "sign_message.h"
-#include "ui_flow_signMessage.h"
+#include "common_ui.h"
 
 static uint8_t processed_size;
 static struct {