d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed EIP-712 strict chain ID check

Browse Source
This commit is contained in:
Alexandre Paillier
2022-09-15 16:43:39 +02:00
parent 35c77ff29c
commit 78c0bfe424
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src_features/signMessageEIP712/field_hash.c
View File

@@ -182,15 +182,6 @@ static bool field_hash_domain_special_fields(const void *const field_ptr,
memcpy(eip712_context->contract_addr, data, data_length); memcpy(eip712_context->contract_addr, data, data_length);
} else if (strncmp(key, "chainId", keylen) == 0) { } else if (strncmp(key, "chainId", keylen) == 0) {
eip712_context->chain_id = u64_from_BE(data, data_length); eip712_context->chain_id = u64_from_BE(data, data_length);
if ((eip712_context->chain_id != 0) && (eip712_context->chain_id != chainConfig->chainId)) {
apdu_response_code = APDU_RESPONSE_CONDITION_NOT_SATISFIED;
PRINTF("EIP712Domain chain ID mismatch, expected 0x%.*h, got 0x%.*h !\n",
sizeof(chainConfig->chainId),
&chainConfig->chainId,
sizeof(eip712_context->chain_id),
&eip712_context->chain_id);
return false;
}
} }
return true; return true;
} }