d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added missing return value checks following recent changes

Browse Source
This commit is contained in:
Alexandre Paillier
2023-10-05 15:01:58 +02:00
parent 9a9e946b50
commit 49da32af8e
14 changed files with 254 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src_bagl/ui_flow_stark_sign.c
View File

@@ -4,6 +4,7 @@
#include "ui_callbacks.h"
#include "ethUtils.h"
#include "starkDisplayUtils.h"
#include "apdu_constants.h"
// clang-format off
UX_STEP_NOCB(ux_stark_limit_order_1_step,
@@ -78,6 +79,16 @@ UX_FLOW(ux_stark_limit_order_flow,
&ux_stark_limit_order_7_step,
&ux_stark_limit_order_8_step);
static void stark_format_address(void) {
if (!getEthDisplayableAddress(dataContext.starkContext.conditionAddress,
strings.tmp.tmp,
sizeof(strings.tmp.tmp),
&global_sha3,
chainConfig->chainId)) {
THROW(APDU_RESPONSE_ERROR_NO_INFO);
}
}
//////////////////////////////////////////////////////////////////////
// clang-format off
UX_STEP_NOCB(ux_stark_transfer_1_step,
@@ -167,11 +178,7 @@ UX_STEP_NOCB_INIT(
UX_STEP_NOCB_INIT(
ux_stark_conditional_transfer_8_step,
bnnn_paging,
getEthDisplayableAddress(dataContext.starkContext.conditionAddress,
strings.tmp.tmp,
sizeof(strings.tmp.tmp),
&global_sha3,
chainConfig->chainId),
stark_format_address(),
{
.title = "Cond. Address",
.text = strings.tmp.tmp