d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix device crash caused by improper memory alignment of the plugin context buffer

Browse Source
This commit is contained in:
Alexandre Paillier
2022-12-01 14:22:23 +01:00
parent 9e2b67552e
commit 3e750e8419
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared_context.h
View File

@@ -65,7 +65,9 @@ typedef struct tokenContext_t {
uint8_t contractAddress[ADDRESS_LENGTH]; uint8_t contractAddress[ADDRESS_LENGTH];
uint8_t methodSelector[SELECTOR_LENGTH]; uint8_t methodSelector[SELECTOR_LENGTH];
}; };
uint8_t pluginContext[5 * INT256_LENGTH]; // This needs to be strictly 4 bytes aligned since pointers to it will be casted as
// plugin context struct pointers (structs that contain up to 4 bytes wide elements)
uint8_t pluginContext[5 * INT256_LENGTH] __attribute__((aligned(4)));
}; };
#ifdef HAVE_STARKWARE #ifdef HAVE_STARKWARE
@@ -77,6 +79,8 @@ typedef struct tokenContext_t {
} tokenContext_t; } tokenContext_t;
_Static_assert((offsetof(tokenContext_t, pluginContext) % 4) == 0, "Plugin context not aligned");
typedef struct publicKeyContext_t { typedef struct publicKeyContext_t {
cx_ecfp_public_key_t publicKey; cx_ecfp_public_key_t publicKey;
char address[41]; char address[41];