d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark pointer to databuffer/workbuffer as const

Browse Source
This commit is contained in:
Jorge Martins
2022-07-15 12:33:19 +02:00
parent 9ea16d9098
commit 2811917658
23 changed files with 43 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/apdu_constants.h
View File

@@ -60,13 +60,13 @@
void handleGetPublicKey(uint8_t p1, void handleGetPublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleProvideErc20TokenInformation(uint8_t p1, void handleProvideErc20TokenInformation(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
@@ -78,46 +78,46 @@ void handleProvideNFTInformation(uint8_t p1,
unsigned int *tx); unsigned int *tx);
void handleSign(uint8_t p1, void handleSign(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleGetAppConfiguration(uint8_t p1, void handleGetAppConfiguration(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleSignPersonalMessage(uint8_t p1, void handleSignPersonalMessage(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleSignEIP712Message(uint8_t p1, void handleSignEIP712Message(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleSetExternalPlugin(uint8_t p1, void handleSetExternalPlugin(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleSetPlugin(uint8_t p1, void handleSetPlugin(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handlePerformPrivacyOperation(uint8_t p1, void handlePerformPrivacyOperation(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
@@ -126,7 +126,7 @@ void handlePerformPrivacyOperation(uint8_t p1,
void handleGetEth2PublicKey(uint8_t p1, void handleGetEth2PublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
@@ -143,7 +143,7 @@ void handleSetEth2WinthdrawalIndex(uint8_t p1,
void handleStarkwareGetPublicKey(uint8_t p1, void handleStarkwareGetPublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
@@ -155,13 +155,13 @@ void handleStarkwareSignMessage(uint8_t p1,
unsigned int *tx); unsigned int *tx);
void handleStarkwareProvideQuantum(uint8_t p1, void handleStarkwareProvideQuantum(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);
void handleStarkwareUnsafeSign(uint8_t p1, void handleStarkwareUnsafeSign(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx); unsigned int *tx);

6
src/eth_plugin_handler.c
View File

@@ -5,7 +5,9 @@
#include "network.h" #include "network.h"
#include "ethUtils.h" #include "ethUtils.h"
void eth_plugin_prepare_init(ethPluginInitContract_t *init, uint8_t *selector, uint32_t dataSize) { void eth_plugin_prepare_init(ethPluginInitContract_t *init,
const uint8_t *selector,
uint32_t dataSize) {
memset((uint8_t *) init, 0, sizeof(ethPluginInitContract_t)); memset((uint8_t *) init, 0, sizeof(ethPluginInitContract_t));
init->selector = selector; init->selector = selector;
init->dataSize = dataSize; init->dataSize = dataSize;
@@ -111,7 +113,7 @@ static bool eth_plugin_perform_init_old_internal(uint8_t *contractAddress,
j++) { j++) {
if (memcmp(init->selector, (const void *) PIC(selectors[j]), SELECTOR_SIZE) == 0) { if (memcmp(init->selector, (const void *) PIC(selectors[j]), SELECTOR_SIZE) == 0) {
if ((INTERNAL_ETH_PLUGINS[i].availableCheck == NULL) || if ((INTERNAL_ETH_PLUGINS[i].availableCheck == NULL) ||
((PluginAvailableCheck) PIC(INTERNAL_ETH_PLUGINS[i].availableCheck)) ()) { ((PluginAvailableCheck) PIC(INTERNAL_ETH_PLUGINS[i].availableCheck))()) {
strlcpy(dataContext.tokenContext.pluginName, strlcpy(dataContext.tokenContext.pluginName,
INTERNAL_ETH_PLUGINS[i].alias, INTERNAL_ETH_PLUGINS[i].alias,
PLUGIN_ID_LENGTH); PLUGIN_ID_LENGTH);

4
src/eth_plugin_handler.h
View File

@@ -6,7 +6,9 @@
#define NO_EXTRA_INFO(ctx, idx) \ #define NO_EXTRA_INFO(ctx, idx) \
(allzeroes(&(ctx.transactionContext.extraInfo[idx]), sizeof(extraInfo_t))) (allzeroes(&(ctx.transactionContext.extraInfo[idx]), sizeof(extraInfo_t)))
void eth_plugin_prepare_init(ethPluginInitContract_t *init, uint8_t *selector, uint32_t dataSize); void eth_plugin_prepare_init(ethPluginInitContract_t *init,
const uint8_t *selector,
uint32_t dataSize);
void eth_plugin_prepare_provide_parameter(ethPluginProvideParameter_t *provideParameter, void eth_plugin_prepare_provide_parameter(ethPluginProvideParameter_t *provideParameter,
uint8_t *parameter, uint8_t *parameter,
uint32_t parameterOffset); uint32_t parameterOffset);

2
src/main.c
View File

@@ -480,7 +480,7 @@ void handleGetWalletId(volatile unsigned int *tx) {
#endif // HAVE_WALLET_ID_SDK #endif // HAVE_WALLET_ID_SDK
uint8_t *parseBip32(const uint8_t *dataBuffer, uint16_t *dataLength, bip32_path_t *bip32) { const uint8_t *parseBip32(const uint8_t *dataBuffer, uint16_t *dataLength, bip32_path_t *bip32) {
if (*dataLength < 1) { if (*dataLength < 1) {
PRINTF("Invalid data\n"); PRINTF("Invalid data\n");
return NULL; return NULL;

2
src/shared_context.h
View File

@@ -219,6 +219,6 @@ extern uint32_t eth2WithdrawalIndex;
#endif #endif
void reset_app_context(void); void reset_app_context(void);
uint8_t *parseBip32(uint8_t *, uint16_t *, bip32_path_t *); const uint8_t *parseBip32(const uint8_t *, uint16_t *, bip32_path_t *);
#endif // _SHARED_CONTEXT_H_ #endif // _SHARED_CONTEXT_H_

2
src/utils.c
View File

@@ -54,7 +54,7 @@ int local_strchr(char *string, char ch) {
return -1; return -1;
} }
uint64_t u64_from_BE(uint8_t *in, uint8_t size) { uint64_t u64_from_BE(const uint8_t *in, uint8_t size) {
uint8_t i = 0; uint8_t i = 0;
uint64_t res = 0; uint64_t res = 0;

2
src/utils.h
View File

@@ -28,7 +28,7 @@ void convertUint256BE(uint8_t* data, uint32_t length, uint256_t* target);
int local_strchr(char* string, char ch); int local_strchr(char* string, char ch);
uint64_t u64_from_BE(uint8_t* in, uint8_t size); uint64_t u64_from_BE(const uint8_t* in, uint8_t size);
bool uint256_to_decimal(const uint8_t* value, size_t value_len, char* out, size_t out_len); bool uint256_to_decimal(const uint8_t* value, size_t value_len, char* out, size_t out_len);

2
src_common/ethUstream.c
View File

@@ -592,7 +592,7 @@ static parserStatus_e processTxInternal(txContext_t *context) {
} }
parserStatus_e processTx(txContext_t *context, parserStatus_e processTx(txContext_t *context,
uint8_t *buffer, const uint8_t *buffer,
uint32_t length, uint32_t length,
uint32_t processingFlags) { uint32_t processingFlags) {
parserStatus_e result; parserStatus_e result;

4
src_common/ethUstream.h
View File

@@ -142,7 +142,7 @@ typedef struct txContext_t {
uint32_t dataLength; uint32_t dataLength;
uint8_t rlpBuffer[5]; uint8_t rlpBuffer[5];
uint32_t rlpBufferPos; uint32_t rlpBufferPos;
uint8_t *workBuffer; const uint8_t *workBuffer;
uint32_t commandLength; uint32_t commandLength;
uint32_t processingFlags; uint32_t processingFlags;
ustreamProcess_t customProcessor; ustreamProcess_t customProcessor;
@@ -157,7 +157,7 @@ void initTx(txContext_t *context,
ustreamProcess_t customProcessor, ustreamProcess_t customProcessor,
void *extra); void *extra);
parserStatus_e processTx(txContext_t *context, parserStatus_e processTx(txContext_t *context,
uint8_t *buffer, const uint8_t *buffer,
uint32_t length, uint32_t length,
uint32_t processingFlags); uint32_t processingFlags);
parserStatus_e continueTx(txContext_t *context); parserStatus_e continueTx(txContext_t *context);

2
src_features/getEth2PublicKey/cmd_getEth2PublicKey.c
View File

@@ -42,7 +42,7 @@ void getEth2PublicKey(uint32_t *bip32Path, uint8_t bip32PathLength, uint8_t *out
void handleGetEth2PublicKey(uint8_t p1, void handleGetEth2PublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/getPublicKey/cmd_getPublicKey.c
View File

@@ -7,7 +7,7 @@
void handleGetPublicKey(uint8_t p1, void handleGetPublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/performPrivacyOperation/cmd_performPrivacyOperation.c
View File

@@ -25,7 +25,7 @@ void decodeScalar(const uint8_t *scalarIn, uint8_t *scalarOut) {
void handlePerformPrivacyOperation(uint8_t p1, void handlePerformPrivacyOperation(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/provideErc20TokenInformation/cmd_provideTokenInfo.c
View File

@@ -101,7 +101,7 @@ void handleProvideErc20TokenInformation(uint8_t p1,
void handleProvideErc20TokenInformation(uint8_t p1, void handleProvideErc20TokenInformation(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
__attribute__((unused)) unsigned int *tx) { __attribute__((unused)) unsigned int *tx) {

2
src_features/provideNFTInformation/cmd_provideNFTInfo.c
View File

@@ -53,7 +53,7 @@ typedef bool verificationAlgo(const cx_ecfp_public_key_t *,
void handleProvideNFTInformation(uint8_t p1, void handleProvideNFTInformation(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/setEth2WithdrawalIndex/cmd_setEth2WithdrawalIndex.c
View File

@@ -5,7 +5,7 @@
void handleSetEth2WithdrawalIndex(uint8_t p1, void handleSetEth2WithdrawalIndex(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
__attribute__((unused)) unsigned int *flags, __attribute__((unused)) unsigned int *flags,
__attribute__((unused)) unsigned int *tx) { __attribute__((unused)) unsigned int *tx) {

2
src_features/setExternalPlugin/cmd_setExternalPlugin.c
View File

@@ -7,7 +7,7 @@
void handleSetExternalPlugin(uint8_t p1, void handleSetExternalPlugin(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

4
src_features/setPlugin/cmd_setPlugin.c
View File

@@ -86,7 +86,7 @@ static pluginType_t getPluginType(char *pluginName, uint8_t pluginNameLength) {
void handleSetPlugin(uint8_t p1, void handleSetPlugin(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {
@@ -248,7 +248,7 @@ void handleSetPlugin(uint8_t p1,
hashId, hashId,
hash, hash,
sizeof(hash), sizeof(hash),
workBuffer + offset, (unsigned char *) (workBuffer + offset),
signatureLen)) { signatureLen)) {
#ifndef HAVE_BYPASS_SIGNATURES #ifndef HAVE_BYPASS_SIGNATURES
PRINTF("Invalid NFT signature\n"); PRINTF("Invalid NFT signature\n");

2
src_features/signMessage/cmd_signMessage.c
View File

@@ -113,7 +113,7 @@ static void feed_value_str(const uint8_t *const data, size_t length, bool is_asc
void handleSignPersonalMessage(uint8_t p1, void handleSignPersonalMessage(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/signMessageEIP712/cmd_signMessage712.c
View File

@@ -5,7 +5,7 @@
void handleSignEIP712Message(uint8_t p1, void handleSignEIP712Message(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/signTx/cmd_signTx.c
View File

@@ -6,7 +6,7 @@
void handleSign(uint8_t p1, void handleSign(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *workBuffer, const uint8_t *workBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

2
src_features/stark_getPublicKey/cmd_stark_getPublicKey.c
View File

@@ -8,7 +8,7 @@
void handleStarkwareGetPublicKey(uint8_t p1, void handleStarkwareGetPublicKey(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
unsigned int *tx) { unsigned int *tx) {

4
src_features/stark_provideQuantum/cmd_stark_provideQuantum.c
View File

@@ -7,7 +7,7 @@
void handleStarkwareProvideQuantum(uint8_t p1, void handleStarkwareProvideQuantum(uint8_t p1,
__attribute__((unused)) uint8_t p2, __attribute__((unused)) uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
__attribute__((unused)) unsigned int *flags, __attribute__((unused)) unsigned int *flags,
__attribute__((unused)) unsigned int *tx) { __attribute__((unused)) unsigned int *tx) {
@@ -35,7 +35,7 @@ void handleStarkwareProvideQuantum(uint8_t p1,
THROW(0x6700); THROW(0x6700);
} }
if (p1 == STARK_QUANTUM_LEGACY) { if (p1 == STARK_QUANTUM_LEGACY) {
addressZero = allzeroes(dataBuffer, 20); addressZero = allzeroes((void *) dataBuffer, 20);
} }
if ((p1 != STARK_QUANTUM_ETH) && !addressZero) { if ((p1 != STARK_QUANTUM_ETH) && !addressZero) {
for (i = 0; i < MAX_ITEMS; i++) { for (i = 0; i < MAX_ITEMS; i++) {

2
src_features/stark_unsafe_sign/cmd_stark_unsafe_sign.c
View File

@@ -8,7 +8,7 @@
void handleStarkwareUnsafeSign(uint8_t p1, void handleStarkwareUnsafeSign(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, const uint8_t *dataBuffer,
uint16_t dataLength, uint16_t dataLength,
unsigned int *flags, unsigned int *flags,
__attribute__((unused)) unsigned int *tx) { __attribute__((unused)) unsigned int *tx) {