d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #574 from LedgerHQ/fbe/remove_ETH_PLUGIN_RESULT_OK_ALIAS

Browse Source 
Remove deprecated ETH_PLUGIN_RESULT_OK_ALIAS from plugin API
This commit is contained in:
François Beutin
2024-05-28 17:40:51 +02:00
committed by GitHub
parent 07a488e25f 5a756975c3
commit 2095776a3f
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
doc/ethapp_plugins.adoc
View File

@@ -85,8 +85,6 @@ typedef struct ethPluginInitContract_t {
uint8_t *selector; // 4 bytes selector uint8_t *selector; // 4 bytes selector
uint32_t dataSize; uint32_t dataSize;
char *alias; // 29 bytes alias if ETH_PLUGIN_RESULT_OK_ALIAS set
uint8_t result; uint8_t result;
} ethPluginInitContract_t; } ethPluginInitContract_t;
@@ -102,7 +100,6 @@ This message is sent when the selector of the data has been parsed. The followin
The following return codes are expected, any other will abort the signing process : The following return codes are expected, any other will abort the signing process :
* ETH_PLUGIN_RESULT_OK : if the plugin can be successfully initialized * ETH_PLUGIN_RESULT_OK : if the plugin can be successfully initialized
* ETH_PLUGIN_RESULT_OK_ALIAS : if a base64 encoded alias of another plugin to call is copied to the _alias_ field. In this case, the dispatcher will follow the alias chain, and the original plugin will only be called to retrieve its name when using a generic user interface
* ETH_PLUGIN_RESULT_FALLBACK : if the signing logic should fallback to the generic one * ETH_PLUGIN_RESULT_FALLBACK : if the signing logic should fallback to the generic one
### ETH_PLUGIN_PROVIDE_PARAMETER ### ETH_PLUGIN_PROVIDE_PARAMETER

1
src/eth_plugin_handler.c
View File

@@ -207,7 +207,6 @@ eth_plugin_result_t eth_plugin_call(int method, void *parameter) {
(uint8_t *) &dataContext.tokenContext.pluginContext; (uint8_t *) &dataContext.tokenContext.pluginContext;
((ethPluginInitContract_t *) parameter)->pluginContextLength = ((ethPluginInitContract_t *) parameter)->pluginContextLength =
sizeof(dataContext.tokenContext.pluginContext); sizeof(dataContext.tokenContext.pluginContext);
((ethPluginInitContract_t *) parameter)->alias = dataContext.tokenContext.pluginName;
break; break;
case ETH_PLUGIN_PROVIDE_PARAMETER: case ETH_PLUGIN_PROVIDE_PARAMETER:
PRINTF("-- PLUGIN PROVIDE PARAMETER --\n"); PRINTF("-- PLUGIN PROVIDE PARAMETER --\n");