d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better context check for EIP712 sign

Browse Source 
It was possible to define empty structs without any fields and right after, trigger the EIP712 sign UI flow for blank domain & message hashes.
Added checks if there is actually anything relevant to sign.
This commit is contained in:
Alexandre Paillier
2022-10-18 11:48:03 +02:00
parent 0b288cd924
commit 109dffc70e
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src_features/signMessageEIP712/commands_712.c
View File

@@ -13,6 +13,7 @@
#include "schema_hash.h" #include "schema_hash.h"
#include "filtering.h" #include "filtering.h"
#include "common_712.h" #include "common_712.h"
#include "ethUtils.h" // allzeroes
/** /**
* Send the response to the previous APDU command * Send the response to the previous APDU command
@@ -185,6 +186,14 @@ bool handle_eip712_sign(const uint8_t *const apdu_buf) {
if (eip712_context == NULL) { if (eip712_context == NULL) {
apdu_response_code = APDU_RESPONSE_CONDITION_NOT_SATISFIED; apdu_response_code = APDU_RESPONSE_CONDITION_NOT_SATISFIED;
}
// if the final hashes are still zero or if there are some unimplemented fields
else if (allzeroes(tmpCtx.messageSigningContext712.domainHash,
sizeof(tmpCtx.messageSigningContext712.domainHash)) ||
allzeroes(tmpCtx.messageSigningContext712.messageHash,
sizeof(tmpCtx.messageSigningContext712.messageHash)) ||
(path_get_field() != NULL)) {
apdu_response_code = APDU_RESPONSE_CONDITION_NOT_SATISFIED;
} else if ((ui_712_get_filtering_mode() == EIP712_FILTERING_FULL) && } else if ((ui_712_get_filtering_mode() == EIP712_FILTERING_FULL) &&
(ui_712_remaining_filters() != 0)) { (ui_712_remaining_filters() != 0)) {
PRINTF("%d EIP712 filters are missing\n", ui_712_remaining_filters()); PRINTF("%d EIP712 filters are missing\n", ui_712_remaining_filters());