PR U: NotaryRegistry E2E round-trip via ganache CLI + in-process solc #25

2026-04-22T14:03:35-07:00

nsatoshi commented

2026-04-22 14:03:35 -07:00

Summary

Adds a headless end-to-end round-trip that spawns the ganache CLI as a child process, deploys NotaryRegistry.sol via in-process solc-js compilation, and exercises services/notaryChain.ts (anchorPlan + finalizeAnchor) against the real chain via ethers v6.

Closes gap-analysis v3 §7.9 / §8.5 — PR Q’s existing E2E covered Postgres only; this one covers the chain adapter boundary the orchestrator actually depends on.

Changes

contracts/NotaryRegistry.sol — add OZ v5 constructor(address initialOwner) Ownable(initialOwner) {} (required by OpenZeppelin v5; contract was written for v4 and would not compile otherwise).
orchestrator/src/services/notaryChain.ts:
- Bug fix: Step tuple ABI shape was (uint8, address, uint256, bytes) — but IComboHandler.Step is (uint8, bytes, address, uint256). Different tuple order → different canonical signature → different function selector → every on-chain call silently reverted with no revert data. Corrected to match.
- Disable JsonRpcProvider response cache (cacheTimeout: -1) so back-to-back anchor+finalize on fast chains no longer read a stale getTransactionCount and collide on nonce.
orchestrator/tests/e2e/helpers/compileNotaryRegistry.ts — in-process solc-js compilation with recursive import resolver (handles ./interfaces/*.sol + @openzeppelin/contracts/...), returns { abi, bytecode } ready for ContractFactory. Avoids any hardhat dependency.
orchestrator/tests/e2e/notaryChainRoundtrip.e2e.test.ts — gated on RUN_E2E=1; 3 tests:
1. anchorPlan writes a PlanRegistered record on-chain (verified via plans(bytes32) read).
2. finalizeAnchor writes a PlanFinalized record, emits the matching receipt hash.
3. anchorPlan falls back to mode: mock cleanly when envs are unset.
orchestrator/package.json — adds ganache@7.9.2, solc@0.8.20 to devDependencies.

Verification

npx tsc --noEmit clean.
npx jest unit suite: 10 suites / 128 tests — unchanged, all passing.
RUN_E2E=1 npx jest --config=jest.e2e.config.js tests/e2e/notaryChainRoundtrip.e2e.test.ts: 3 / 3 passing.

Notes

No UI changes. Entirely backend / test infrastructure.
Mock-fallback path for anchorPlan is preserved — production deployments without chain envs degrade gracefully.
Does not yet encode full plan steps into registerPlan — PR E’s SWIFT step IDs will land that separately.

## Summary Adds a headless end-to-end round-trip that spawns the ganache CLI as a child process, deploys `NotaryRegistry.sol` via in-process `solc-js` compilation, and exercises `services/notaryChain.ts` (`anchorPlan` + `finalizeAnchor`) against the real chain via ethers v6. Closes gap-analysis v3 §7.9 / §8.5 — PR Q’s existing E2E covered Postgres only; this one covers the chain adapter boundary the orchestrator actually depends on. ## Changes - `contracts/NotaryRegistry.sol` — add OZ v5 `constructor(address initialOwner) Ownable(initialOwner) {}` (required by OpenZeppelin v5; contract was written for v4 and would not compile otherwise). - `orchestrator/src/services/notaryChain.ts`: - **Bug fix**: Step tuple ABI shape was `(uint8, address, uint256, bytes)` — but `IComboHandler.Step` is `(uint8, bytes, address, uint256)`. Different tuple order → different canonical signature → different function selector → every on-chain call silently reverted with no revert data. Corrected to match. - Disable JsonRpcProvider response cache (`cacheTimeout: -1`) so back-to-back anchor+finalize on fast chains no longer read a stale `getTransactionCount` and collide on nonce. - `orchestrator/tests/e2e/helpers/compileNotaryRegistry.ts` — in-process `solc-js` compilation with recursive import resolver (handles `./interfaces/*.sol` + `@openzeppelin/contracts/...`), returns `{ abi, bytecode }` ready for `ContractFactory`. Avoids any hardhat dependency. - `orchestrator/tests/e2e/notaryChainRoundtrip.e2e.test.ts` — gated on `RUN_E2E=1`; 3 tests: 1. `anchorPlan` writes a `PlanRegistered` record on-chain (verified via `plans(bytes32)` read). 2. `finalizeAnchor` writes a `PlanFinalized` record, emits the matching receipt hash. 3. `anchorPlan` falls back to `mode: mock` cleanly when envs are unset. - `orchestrator/package.json` — adds `ganache@7.9.2`, `solc@0.8.20` to devDependencies. ## Verification - `npx tsc --noEmit` clean. - `npx jest` unit suite: **10 suites / 128 tests** — unchanged, all passing. - `RUN_E2E=1 npx jest --config=jest.e2e.config.js tests/e2e/notaryChainRoundtrip.e2e.test.ts`: **3 / 3 passing**. ## Notes - No UI changes. Entirely backend / test infrastructure. - Mock-fallback path for `anchorPlan` is preserved — production deployments without chain envs degrade gracefully. - Does not yet encode full plan steps into `registerPlan` — PR E’s SWIFT step IDs will land that separately.

nsatoshi merged commit a9fbb39889 into main

2026-04-22 14:11:53 -07:00

nsatoshi deleted branch devin/1776891791-pr-u-notary-e2e

2026-04-22 14:11:54 -07:00

nsatoshi referenced this issue from a commit

2026-04-22 14:11:56 -07:00

PR #25 (squash-merged via Gitea API)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: d-bis/CurrenciCombo#25